Open
Conversation
szamfir-skylight
previously approved these changes
Mar 10, 2026
Contributor
szamfir-skylight
left a comment
There was a problem hiding this comment.
Looks awesome! Thanks for this and for going back and forth when needed
szamfir-skylight
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a standalone
nbs-ingressHelm chart that decouples all NBS7 ingress routing from the application charts. Supports both NGINX and Traefik ingress providers via feature flags (nginx.enabled/traefik.enabled), allowing STLTs to migrate to Traefik independently of their NBS7 application version. Also includes Traefik controller Helm values for AWS (EKS) and Azure (AKS) deployments.Adds a separate
nbs6-ingressHelm chart for CDC and Montana environments that run NBS6 (Classic/WildFly) in a container. This decouples the NBS6 ingress routing from the nbs6 application chart, supporting both NGINX and Traefik providers with the same flag pattern.Creating a new Helm chart?
Yes —
charts/nbs-ingress/is a full Helm chart containing templates for all NBS7 ingress resources (main app routes, cached static assets, data ingestion, middlewares, and optional NiFi).charts/nbs6-ingress/is a full Helm chart for NBS6 Classic ingress routing (main routes, cached static assets, and middlewares).charts/traefik/contains only Helm values files used with the upstreamtraefik/traefikchart.Notes
modernization-apianddataingestion-service— those templates have been removed and thetraefikIngress.enabledvalues reset tofalseappVersion— not pinned in values files