Skip to content

fix nodeSelector#1315

Merged
szamfir-skylight merged 1 commit intomainfrom
sgz-fix-selector
Mar 4, 2026
Merged

fix nodeSelector#1315
szamfir-skylight merged 1 commit intomainfrom
sgz-fix-selector

Conversation

@szamfir-skylight
Copy link
Contributor

Description

Adds node selector to prevent accidental deployments on windows nodes.

Please include a summary of the changes and any key information a reviewer may need. Review the appropriate section below.

Creating a new Helm chart?

  1. Does the service require an ingress?
    • Kubernetes Ingress resource are PATH based and only handled by modernization-api and dataingestion-service helm charts.
    • Currently, names of Kubernetes services have to be predictable if an ingress needs to point to them
  2. Chart directory structure (specific environment values.yaml files are allowed at the same level as values.yaml)
    |── charts
        ├── new-helm-chart
            ├── templates
            |   ├── tests
            |   ├── helpers.tpl
            |   ├── *.yaml
            |   └─ Chart.yaml
            ├── values.yaml
            └─  README.md
    
  3. Do not include secret values anywhere in a Helm chart, take special care when creating values.yaml
  4. values.yaml is annotated to include parameter description and format as appropriate.
    • values.yaml is considered the production/default parameter file and should point to publically available container registries, if the service is publically available.

Updating a Helm Chart?

  1. Ensure no secrets have been committed.
  2. Ensure updates to existing Helm charts follow the guidelines contained in section Creating a new Helm chart.

@szamfir-skylight szamfir-skylight requested a review from a team March 4, 2026 14:55
@szamfir-skylight szamfir-skylight merged commit a7c3abd into main Mar 4, 2026
3 checks passed
@szamfir-skylight szamfir-skylight deleted the sgz-fix-selector branch March 4, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants