Skip to content

[CTHULHU-12] Remove deployment references to xml-hl7-parser-service#1314

Draft
timoballard wants to merge 1 commit intomainfrom
tdb/cthulhu-12_xml-hl7-parser-deployment
Draft

[CTHULHU-12] Remove deployment references to xml-hl7-parser-service#1314
timoballard wants to merge 1 commit intomainfrom
tdb/cthulhu-12_xml-hl7-parser-deployment

Conversation

@timoballard
Copy link

Description

Following on CDCgov/NEDSS-NNDSS-Case-Notifications#113, removing references to xml-hl7-parser-service

Creating a new Helm chart?

  1. Does the service require an ingress?
    • Kubernetes Ingress resource are PATH based and only handled by modernization-api and dataingestion-service helm charts.
    • Currently, names of Kubernetes services have to be predictable if an ingress needs to point to them
  2. Chart directory structure (specific environment values.yaml files are allowed at the same level as values.yaml)
    |── charts
        ├── new-helm-chart
            ├── templates
            |   ├── tests
            |   ├── helpers.tpl
            |   ├── *.yaml
            |   └─ Chart.yaml
            ├── values.yaml
            └─  README.md
    
  3. Do not include secret values anywhere in a Helm chart, take special care when creating values.yaml
  4. values.yaml is annotated to include parameter description and format as appropriate.
    • values.yaml is considered the production/default parameter file and should point to publically available container registries, if the service is publically available.

Updating a Helm Chart?

  1. Ensure no secrets have been committed.
  2. Ensure updates to existing Helm charts follow the guidelines contained in section Creating a new Helm chart.

Copy link
Contributor

@szamfir-skylight szamfir-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good in removing xml-hl7-parser-service. My question is if we will be keeping this service in place for the next release. I think we will not be ready to release the changes you have made so far by the end of March. As such we should just toggle the flags in our deployments and subsequently not deploy this service.

For development purposes we will point to a development container image in our enviroments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants