Skip to content

feat: add iisConnection override#1312

Merged
cmansky merged 2 commits intomainfrom
cm/iis
Feb 25, 2026
Merged

feat: add iisConnection override#1312
cmansky merged 2 commits intomainfrom
cm/iis

Conversation

@cmansky
Copy link
Contributor

@cmansky cmansky commented Feb 25, 2026

Description

Add iisConnection.txt file override to helmchart so we don't have to embed secrets into the containers.

Creating a new Helm chart?

  1. Does the service require an ingress?
    • Kubernetes Ingress resource are PATH based and only handled by modernization-api and dataingestion-service helm charts.
    • Currently, names of Kubernetes services have to be predictable if an ingress needs to point to them
  2. Chart directory structure (specific environment values.yaml files are allowed at the same level as values.yaml)
    |── charts
        ├── new-helm-chart
            ├── templates
            |   ├── tests
            |   ├── helpers.tpl
            |   ├── *.yaml
            |   └─ Chart.yaml
            ├── values.yaml
            └─  README.md
    
  3. Do not include secret values anywhere in a Helm chart, take special care when creating values.yaml
  4. values.yaml is annotated to include parameter description and format as appropriate.
    • values.yaml is considered the production/default parameter file and should point to publically available container registries, if the service is publically available.

Updating a Helm Chart?

  1. Ensure no secrets have been committed.
  2. Ensure updates to existing Helm charts follow the guidelines contained in section Creating a new Helm chart.

@cmansky cmansky marked this pull request as ready for review February 25, 2026 20:00
Copy link
Contributor

@szamfir-skylight szamfir-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cmansky cmansky merged commit 11ec52d into main Feb 25, 2026
3 checks passed
@cmansky cmansky deleted the cm/iis branch February 25, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants