verbs compile error on cooley

[JohnPJenkins]

Ran into this when rebuilding earlier today from master:

/home/jenkins/work/sds/cci/src/plugins/ctp/verbs/ctp_verbs_api.c:2985:6: error: assigning to 'int' from incompatible type 'void'
        ret = rdma_destroy_ep(vconn->id);

(at https://github.com/CCI/cci/blob/master/src/plugins/ctp/verbs/ctp_verbs_api.c#L2985)

Looking into it, there's actually two possible function definitions for rdma_destroy_ep - a locally defined one at https://github.com/CCI/cci/blob/master/src/plugins/ctp/verbs/ctp_verbs_api.c#L1061 and one in rdma/rdma_cma.h. Both have the same void-returning signature. Would fix myself, but I'm unsure what the intent is here - is that call supposed to be rdma_destroy_id, which does return an int, or should the error-checking code be dropped out? I'd guess the latter given the comments.

[rajachan]

+1. I'm seeing the same issue too. Dropping the error checking code seems to work just fine:

diff --git a/src/plugins/ctp/verbs/ctp_verbs_api.c b/src/plugins/ctp/verbs/ctp_verbs_api.c
index 06da1f4..e187ebd 100644
--- a/src/plugins/ctp/verbs/ctp_verbs_api.c
+++ b/src/plugins/ctp/verbs/ctp_verbs_api.c
@@ -2982,12 +2982,7 @@ verbs_handle_disconnected(cci__ep_t * ep, struct rdma_cm_event *cm_evt)
        /* Either way, we got the DISCONNECTED event, it is safe to cleanup
         * the QP and CM id.
         */
-       ret = rdma_destroy_ep(vconn->id);
-       if (ret == -1) {
-               ret = errno;
-               debug(CCI_DB_WARN, "%s: rdma_destroy_ep() returned %s",
-                     __func__, strerror(ret));
-       }
+       rdma_destroy_ep(vconn->id);

        if (!vconn->cci_disconn) {
                verbs_destroy_conn(ep, conn);