Skip to content

Commit 42db7c3

Browse files
authored
Merge pull request #19 from CAPS-DGU/feat/#16-security
[fix] #16 Auth 어노테이션을 사용하도록 수정
2 parents e57ccc0 + ea509ea commit 42db7c3

3 files changed

Lines changed: 10 additions & 11 deletions

File tree

src/main/java/kr/dgucaps/caps/domain/member/controller/MemberApi.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
import jakarta.validation.Valid;
1010
import kr.dgucaps.caps.domain.member.dto.request.UpdateMemberRequest;
1111
import kr.dgucaps.caps.domain.member.dto.response.MemberInfoResponse;
12-
import kr.dgucaps.caps.domain.member.entity.Member;
1312
import kr.dgucaps.caps.global.common.SuccessResponse;
1413
import org.springframework.http.ResponseEntity;
15-
import org.springframework.security.core.annotation.AuthenticationPrincipal;
1614
import org.springframework.web.bind.annotation.PathVariable;
1715
import org.springframework.web.bind.annotation.RequestBody;
1816

@@ -27,7 +25,7 @@ public interface MemberApi {
2725
content = @Content(mediaType = "application/json",
2826
schema = @Schema(implementation = MemberInfoResponse.class))
2927
)
30-
ResponseEntity<SuccessResponse<?>> getMemberInfo(@AuthenticationPrincipal(expression = "member") Member member);
28+
ResponseEntity<SuccessResponse<?>> getMemberInfo(Long memberId);
3129

3230
@Operation(
3331
summary = "다른 회원 정보 조회",
@@ -50,6 +48,6 @@ public interface MemberApi {
5048
content = @Content(mediaType = "application/json",
5149
schema = @Schema(implementation = MemberInfoResponse.class))
5250
)
53-
ResponseEntity<SuccessResponse<?>> updateMember(@AuthenticationPrincipal(expression = "member") Member member,
51+
ResponseEntity<SuccessResponse<?>> updateMember(Long memberId,
5452
@Valid @RequestBody UpdateMemberRequest request);
5553
}

src/main/java/kr/dgucaps/caps/domain/member/controller/MemberController.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,11 @@
22

33
import jakarta.validation.Valid;
44
import kr.dgucaps.caps.domain.member.dto.request.UpdateMemberRequest;
5-
import kr.dgucaps.caps.domain.member.entity.Member;
65
import kr.dgucaps.caps.domain.member.service.MemberService;
6+
import kr.dgucaps.caps.global.annotation.Auth;
77
import kr.dgucaps.caps.global.common.SuccessResponse;
88
import lombok.RequiredArgsConstructor;
99
import org.springframework.http.ResponseEntity;
10-
import org.springframework.security.core.annotation.AuthenticationPrincipal;
1110
import org.springframework.web.bind.annotation.*;
1211

1312
@RestController
@@ -18,8 +17,8 @@ public class MemberController implements MemberApi {
1817
private final MemberService memberService;
1918

2019
@GetMapping("/me")
21-
public ResponseEntity<SuccessResponse<?>> getMemberInfo(@AuthenticationPrincipal(expression = "member") Member member) {
22-
return SuccessResponse.ok(memberService.getMemberInfo(member.getId()));
20+
public ResponseEntity<SuccessResponse<?>> getMemberInfo(@Auth Long memberId) {
21+
return SuccessResponse.ok(memberService.getMemberInfo(memberId));
2322
}
2423

2524
@GetMapping("/{memberId}")
@@ -28,9 +27,9 @@ public ResponseEntity<SuccessResponse<?>> getOtherMemberInfo(@PathVariable("memb
2827
}
2928

3029
@PatchMapping("/me")
31-
public ResponseEntity<SuccessResponse<?>> updateMember(@AuthenticationPrincipal(expression = "member") Member member,
30+
public ResponseEntity<SuccessResponse<?>> updateMember(@Auth Long memberId,
3231
@Valid @RequestBody UpdateMemberRequest request) {
33-
return SuccessResponse.ok(memberService.updateMember(member, request));
32+
return SuccessResponse.ok(memberService.updateMember(memberId, request));
3433
}
3534

3635
// @DeleteMapping("/user/{userId}")

src/main/java/kr/dgucaps/caps/domain/member/service/MemberService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ public MemberInfoResponse getMemberInfo(Long memberId) {
2424
}
2525

2626
@Transactional
27-
public MemberInfoResponse updateMember(Member member, UpdateMemberRequest request) {
27+
public MemberInfoResponse updateMember(Long memberId, UpdateMemberRequest request) {
28+
Member member = memberRepository.findById(memberId)
29+
.orElseThrow(() -> new EntityNotFoundException(ErrorCode.MEMBER_NOT_FOUND));
2830
member.updateMember(request.comment(), request.profileImageUrl());
2931
return MemberInfoResponse.from(member);
3032
}

0 commit comments

Comments
 (0)