-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
Just documenting this issue I highlighted in the code a while back:
CABLE/src/offline/cable_driver_common.F90
Lines 166 to 179 in 8e20bac
| ! TODO(Sean): we should not be setting namelist parameters in the following if | |
| ! block - all options are all configurable via the namelist file and is | |
| ! unclear that these options are being overwritten. A better approach would be | |
| ! to error for bad combinations of namelist parameters. | |
| IF (icycle > CASAONLY_ICYCLE_MIN) THEN | |
| icycle = icycle - CASAONLY_ICYCLE_MIN | |
| CASAONLY = .TRUE. | |
| CABLE_USER%CASA_DUMP_READ = .TRUE. | |
| CABLE_USER%CASA_DUMP_WRITE = .FALSE. | |
| ELSE IF (icycle == 0) THEN | |
| CABLE_USER%CASA_DUMP_READ = .FALSE. | |
| spincasa = .FALSE. | |
| CABLE_USER%CALL_POP = .FALSE. | |
| END IF |
Setting icycle to a value greater than 10 is redundant, should we remove it?
Metadata
Metadata
Assignees
Labels
No labels