Skip to content

relax torch version check to 2.1+ for checkpointers #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marsmiao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

relax torch version check to 2.1+ for checkpointers #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bytecheckpoint/checkpointer/ddp_checkpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ def save(
logger.info("Start save function call. ")

# Check version.
assert torch.__version__.strip() < "2.6.0" and torch.__version__.strip() >= "2.1.0", (
"ByteCheckpoint now only support torch version from 2.1 to 2.5"
assert "2.1.0" <= torch.__version__.strip(), (
"ByteCheckpoint now only support torch version from 2.1 and above"
)
# Check role.
if role and role not in SUPPORTED_ROLE_SUFFIX_TYPES:
Expand Down
4 changes: 2 additions & 2 deletions bytecheckpoint/checkpointer/fsdp2_checkpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ def save(
logger.warning("Unsupported role %s, will use default role instead", role)
role = SUPPORTED_ROLE_SUFFIX_TYPES[DEFAULT_STR]
# Check version.
assert "2.1.0" <= torch.__version__.strip() and torch.__version__.strip() < "2.6.0", (
"ByteCheckpoint now only support torch version from 2.1 to 2.5"
assert "2.1.0" <= torch.__version__.strip(), (
"ByteCheckpoint now only support torch version from 2.1 and above"
)
# Check supported components.
cls.check_supported_components(checkpoint_state, FSDP_SUPPORTED_TYPES)
Expand Down
4 changes: 2 additions & 2 deletions bytecheckpoint/checkpointer/fsdp_checkpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ def save(
logger.warning("Unsupported role %s, will use default role instead", role)
role = SUPPORTED_ROLE_SUFFIX_TYPES[DEFAULT_STR]
# Check version.
assert "2.1.0" <= torch.__version__.strip() and torch.__version__.strip() < "2.6.0", (
"ByteCheckpoint now only support torch version from 2.1 to 2.5"
assert "2.1.0" <= torch.__version__.strip(), (
"ByteCheckpoint now only support torch version from 2.1 and above"
)
# Check supported components.
cls.check_supported_components(checkpoint_state, FSDP_SUPPORTED_TYPES)
Expand Down