[Burn-P3+ Prometheus Bug]: Incomplete Greenup, Curing, etc definitions by Season cause crashes

[shreeramsenthi]

Contact Details

No response

What happened?

The fire growth options (such as green up, curing, etc) allow values to be set by season. Default values are used if these tables are empty, but if values are present but not all seasons are accounted for (either explicitly or implicitly with "All" / NA values) zero vector values are created that cause problems.

Solution: Better generalized error handling to make sure datasheets of this type account for all sampled (though not necessarily all defined) seasons, causes, etc.

What component are you seeing the problem on?

No response

Relevant log output

No response

Approvals Process

• Testing For Issue
• Merge

[shreeramsenthi]

Actually, if (for example) a user specifies the green up condition for Spring but doesn't specify any information about green up for Summer, should we insert the default value for Green up for Summer (with a warning), or should we just error out and report the problem? @BadgerOnABike @katieb1

[BadgerOnABike]

Hmm, I think defaults are tougher to assume based on seasons as seasons don't necessarily mean a specific set of weeks. For example if there is an early spring and late spring defined but greenup and curing are only define for early spring, what assumption do we make for late spring?

From that perspective I'm a fan of error out and report.