6.0.0-RC1 feedback

[Hlavtox]

Cannot autowire service "BulkGate\PrestaShop\Controller\AdminController": argument "$container" of method "PrestaShopBundle\Controller\Admin\FrameworkBundleAdminController::setContainer()" references interface "Psr\Container\ContainerInterface" but no such service exists. You should maybe alias this interface to the existing "service_container" service.

Cache is absolutely clean.

After deleting the module completely and installing it again, BO works.

When clicking Configure in Module manager or the left menu entry, I get:

cc @lukaspijak

[lukaspijak]

What version of prestashop do you have?

[Hlavtox]

@lukaspijak 9.0.0

[MartinKreizl]

PR #11 fix

[lukaspijak]

https://github.com/BulkGate/prestasms/releases/tag/6.0.0-RC2

[Hlavtox]

@lukaspijak Works perfectly now, good job!

Last issue I see is a small visual issue after their backoffice rebranding.

Maybe you could use actionGetAdminOrderButtons instead and just slap a button to the toolbar. Like this:

[Hlavtox]

@lukaspijak Plus please try to think about positioning of the entry in left menu. SMS settings is a think where you go once a year at most, and now it's on the top in the SELL section. :-)

[MartinKreizl]

@lukaspijak Plus please try to think about positioning of the entry in left menu. SMS settings is a think where you go once a year at most, and now it's on the top in the SELL section. :-)

@Hlavtox Currently, we have 2 top-level menu items. Maybe the ideal compromise is to keep "BulkGate SMS" as it is and find a different placement for "BulkGate Debug", which is used for diagnostics and therefore does not need to be so prominent. What do you consider best practice?

[lukaspijak]

Maybe you could use actionGetAdminOrderButtons instead and just slap a button to the toolbar. Like this:

We wanted to place the button here but we had some struggles.

[Hlavtox]

@MartinKreizl IMHO it would be best to leave it on the bottom or put it into the Advanced parameters section. As an admin or a merchant, you don't really go there. The messages templates are configured once and that's it.

And the BulkGate Debug section doesn't really have the be there at all, maybe in debug mode, but definitely not in production mode.

@lukaspijak

We wanted to place the button here but we had some struggles.

Do you remember what was wrong? If the hook implementation sucks I can fix it for PrestaShop 9.0.1. I will have a look tommorow and create a POC with the syntax working both before and after BO rebrand.

[lukaspijak]

Problem is that is not only button, but it shows favorite templates, but you can create PR with alternative button for this.