-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Description
In previous tickets, all trivial duplicate elements were removed:
The remaining duplicates required non-trivial effort and their comments have been collected here:
AdvancedPowerStrip
- one uses "ControlStrategyLightingType" and the other "ControlStrategyGeneralType", otherwise identical
- suggestion: rename to "AdvancedLightingPowerStrip" and "AdvancedGeneralPowerStrip"
AssemblyType
- both instances contain different documentation and enumeration
- suggestion: rename to "WindowAssemblyType" and "SkylightAssemblyType"
Building
- first instance is already of type "BuildingType"
- second and third instance are identical
- suggestion: create base element "LinkedBuilding" and reference with second and third instance
CBECS
- both instances already of type "CBECSType"
- suggestion: rename to "ClimateZoneTypeCVECS" and "ScenarioTypeCVECS"
Capacity
- first instance is tied to system capacity
- remaining instances are identical and tied to equipment
- suggestion: create base element "EquipmentCapacity" and reference with all but first instance
ClimateZone
- every instance has a unique enumeration list
- suggestion: rename each element to include it's parent
CommunicationProtocol
- first instance references "CommunicationProtocolAnalogType" and second "CommunicationProtocolDigitalType"
- suggestion: rename to "CommunicationProtocolAnalog" and "CommunicationProtocolDigital"
Control
- all instances reference a different type or have a different documentation
- will be taken care of if "Controls" is consolidated
- suggestion a: consolidate all "ControlGeneral" by homoginizing the documentation
- suggestion b: rename all "Control" elements by appending their type and/or parent
ControlSensor
- the first instance is an "Occupancy" control for "ControlGeneralType" and contains no restrictions
- the second instance is a "Daylighting" control for "ControlLightingType"
- the third instance is an "Occupancy" control for "ControlLightingType" and has an enumerated list
- suggestion: rename to "ControlSensorGeneralOccupancy", "ControlSensorDaylighting" and "ControlSensorLightingOccupancy", respectively
ControlStrategy
- all instances reference a different type or have a different documentation
- suggestion a: consolidate all "ControlGeneral" by homoginizing the documentation
- suggestion b: rename all "ControlStrategy" elements by appending their type and/or parent
ControlSystemTypes
- all instances are identical save for documentation
- suggestion: rename to "HeatingPlantControlSystemTypes", "CoolingPlantControlSystemTypes" and "CondenserPlantControlSystemTypes"
Controls
- all instances reference a different type or have a different documentation
- suggestion a: consolidate all "Controls" by homoginizing the documentation
- suggestion b: rename all "Controls" elements by appending their type and/or parent
ConveyanceSystems
- the first instance is under "Facilities" > "Systems" and references a very detailed "ConveyanceSystemType"
- the second instance is under "MeasureType" > "TechnologyCategories" and has a very basic descriptive content
- suggestion: rename first instance "FacilityConveyanceSystems" or the second "ConveyanceSystemsMeasurements"
Facility
- first instance is complex, remaining instances are simpler but duplicates with minor documentation changes
- suggestion: create base element "linkedFacility" and reference with second and third instances
HeatPump
- both instances are completely seperate
- suggestion: rename second instance to "HotWaterHeatingPump" or similar
LampLabel
- all instances are unique enumerations
- suggestion: rename to include parent, such as "CompactFluorescentLampLabel" or "IncandescentLampLabel"
Manual
- both instances nearly identical except for each use a slightly different type of "ControlStrategy"
- suggestion: rename to "ControlGeneralTypeManual" and "ControlLightingTypeManual" or consolidate "ControlStrategy"
MeasureName
- nearly all instances are unique enumerations
- suggestion: rename to include parent, such as "LightingImprovementsMeasureName" or "ServiceHotWaterSystemsMeasureName"
Other
- most instances are unique
- some instances are simply referencing "OtherType"
- Suggestion: merge all "OtherType" references into one base "Other" element, then rename all remaining instances to be unique
OtherControlTechnology
- both instances nearly identical except for each use a slightly different type of "ControlStrategy"
- suggestion: rename to "OtherGeneralControlTechnology" and "OtherLightingControlTechnology" or consolidate "ControlStrategy"
Section
- third instance defines a section, first and second instances list section IDs
- suggestion: create base element "LinkedSection" and reference with first and second instance
Site
- third instance refers "SiteType", first and second instances list site IDs
- suggestion: create base element "LinkedSite" and reference with first and second instance
SiteEnergyUse
- all instances unique
- suggestion: rename first to "SiteAnnualEnergyUse" or second to "SiteEnergyUseTypes"
SourceEnergyUse
- all instances unique
- suggestion: rename both
Space
- first instance defines a space, second instance lists space IDs
- suggestion: create base element "LinkedSpace" and reference with second instance
ThermalZone
- third instance refers "ThermalZoneType", first and second instances list thermal zone IDs
- suggestion: create base element "LinkedThermalZone" and reference with first and second instance
Timer
- both instances nearly identical except for each use a slightly different type of "ControlStrategy"
- suggestion: rename to "GeneralTimer" and "LightingTimer" or consolidate "ControlStrategy"
WaterSideEconomizer
- both instances nearly identical except one has "WaterSideEconomizerTemperatureSetpoint"
- suggestion: add "WaterSideEconomizerTemperatureSetpoint" to the other instance, then merge and reference both instances
WaterUseType
- all instances unique
- suggestion: rename second instance "AnnualWaterUse"
Metadata
Metadata
Assignees
Labels
No labels