Skip to content

Commit 08bb56d

Browse files
authored
Merge pull request #121 from pierrekamel5/master
nothing shows up despite the emulator showing that it has content
2 parents 75b1eb1 + 7323722 commit 08bb56d

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

widget/app.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@
143143
function replaceImg(finalSrc) {
144144
var elem = $("<img>");
145145
elem[0].onload = function () {
146-
buildfire.spinner.hide();
147146
element.attr("src", finalSrc);
148147
elem.remove();
149148
};

widget/bookmarkHandler.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ var bookmarks = {
5858
buildfire.bookmarks ? buildfire.bookmarks.getAll(cb) : cb(null, []);
5959
},
6060
sync: function sync($scope) {
61+
buildfire.spinner.show();
6162
this._getAll(function (bookmarks) {
6263
console.log(bookmarks);
6364

widget/controllers/widget.home.controller.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@
231231
bookmarks.sync($scope);
232232
handleBookmarkNav();
233233

234-
Buildfire.spinner.hide();
235234
isInit = false;
236235

237236
function checkFeedEquality(currentItems, fetchedItems) {
@@ -507,9 +506,6 @@
507506
nextChunkDataIndex = nextChunkDataIndex + 1;
508507
nextChunk = null;
509508
WidgetHome.busy = false;
510-
if (!isInit) Buildfire.spinner.hide();
511-
} else {
512-
if (!isInit) Buildfire.spinner.hide();
513509
}
514510
bookmarks.sync($scope);
515511
viewedItems.sync($scope.WidgetHome.items);

widget/controllers/widget.media.controller.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
$rootScope.deviceHeight = window.innerHeight;
1111
$rootScope.deviceWidth = window.innerWidth;
1212

13-
buildfire.auth.onLogin(function () {
13+
Buildfire.auth.onLogin(function () {
1414
bookmarks.sync($scope);
1515
});
1616

17-
buildfire.auth.onLogout(function () {
17+
Buildfire.auth.onLogout(function () {
1818
bookmarks.sync($scope);
1919
if (WidgetMedia.data.readRequiresLogin) {
2020
Location.goToHome();
@@ -367,7 +367,7 @@
367367
$rootScope.showFeed = false;
368368
initScrollHandler();
369369
if (WidgetMedia.data && WidgetMedia.data.design && WidgetMedia.data.design.itemDetailsLayout === 'Feed_Layout_3') {
370-
buildfire.spinner.show();
370+
Buildfire.spinner.show();
371371
}
372372
};
373373

@@ -479,7 +479,7 @@
479479
* will be called when you click play button
480480
*/
481481
WidgetMedia.playAudio = function () {
482-
buildfire.history.push('Now Playing', {});
482+
Buildfire.history.push('Now Playing', {});
483483
Location.goTo('#/nowplaying');
484484

485485
/* WidgetMedia.audio.playing = true;
@@ -568,7 +568,7 @@
568568
}
569569
};
570570

571-
buildfire.device.share(options, callback);
571+
Buildfire.device.share(options, callback);
572572
};
573573

574574
WidgetMedia.addNote = function () {
@@ -584,11 +584,11 @@
584584
if (err) throw err;
585585
console.log(data);
586586
};
587-
// buildfire.input.showTextDialog(options, callback);
588-
buildfire.notes.openDialog(options, callback);
587+
// Buildfire.input.showTextDialog(options, callback);
588+
Buildfire.notes.openDialog(options, callback);
589589
};
590590

591-
buildfire.notes && buildfire.notes.onSeekTo && buildfire.notes.onSeekTo(function (data) {
591+
Buildfire.notes && Buildfire.notes.onSeekTo && Buildfire.notes.onSeekTo(function (data) {
592592
WidgetMedia.item.seekTo = data.time;
593593
if (WidgetMedia.item && WidgetMedia.item.seekTo && WidgetMedia.medium === MEDIUM_TYPES.AUDIO) {
594594
WidgetMedia.playAudio();

0 commit comments

Comments
 (0)