From cb24aad1f9e70f9c6981edf2083d67140a6b015c Mon Sep 17 00:00:00 2001 From: vvchens Date: Thu, 9 Feb 2023 01:01:21 -0500 Subject: [PATCH 1/5] Fix cast type error --- percy-csharp-selenium/Percy.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/percy-csharp-selenium/Percy.cs b/percy-csharp-selenium/Percy.cs index 7e093b6..b07c805 100644 --- a/percy-csharp-selenium/Percy.cs +++ b/percy-csharp-selenium/Percy.cs @@ -272,7 +272,7 @@ private String BuildSnapshotJS(String enableJavaScript) { StringBuilder jsBuilder = new StringBuilder(); // the double {{ and }} are needed to escape the curly braces - jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0} }})\n", enableJavaScript.ToLower())); + jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0}, stringfy_response: true }})\n", enableJavaScript.ToLower())); return jsBuilder.ToString(); } @@ -282,4 +282,4 @@ private void Log(String message) } } -} \ No newline at end of file +} From 8877b7d75320dad3be2703e99057b7f10d34d955 Mon Sep 17 00:00:00 2001 From: vvchens Date: Thu, 9 Feb 2023 01:48:54 -0500 Subject: [PATCH 2/5] Remove .Net4.5 4.6 4.7 --- percy-csharp-selenium/percy-csharp-selenium.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/percy-csharp-selenium/percy-csharp-selenium.csproj b/percy-csharp-selenium/percy-csharp-selenium.csproj index 53850c9..c8c9c98 100644 --- a/percy-csharp-selenium/percy-csharp-selenium.csproj +++ b/percy-csharp-selenium/percy-csharp-selenium.csproj @@ -2,7 +2,7 @@ Exe - netcoreapp3.1;net45;net46;net47;net48 + netcoreapp3.1;net48 percy_csharp_selenium 1.0.1-alpha 1.0.1-alpha From 8e8570e035fa00236a357ba62bf008a3f2a0e903 Mon Sep 17 00:00:00 2001 From: vvchens Date: Thu, 9 Feb 2023 01:51:09 -0500 Subject: [PATCH 3/5] Update README.md --- README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 4c09563..e6fd849 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,8 @@ +Forked from [Origin](https://github.com/BrowserStackCE/percy-csharp-selenium), fixed a cast type error and remove .Net 4.5 4.6 4.7 + # Percy C# Selenium -[Percy](https://percy.io) visual testing for C#.NET Selenium. (Supports both .NET Core and .NET Framework - 4.5 to 4.8) +[Percy](https://percy.io) visual testing for C#.NET Selenium. (Supports both .NET Core and .NET Framework - 4.8) ## Requirements From 520ccc6f3269d2e15eb7e3c8106c8127e3ce9c1e Mon Sep 17 00:00:00 2001 From: vvchens Date: Thu, 9 Feb 2023 12:30:09 -0500 Subject: [PATCH 4/5] Update Percy.cs --- percy-csharp-selenium/Percy.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/percy-csharp-selenium/Percy.cs b/percy-csharp-selenium/Percy.cs index b07c805..dbcb9dc 100644 --- a/percy-csharp-selenium/Percy.cs +++ b/percy-csharp-selenium/Percy.cs @@ -136,7 +136,7 @@ public void Snapshot(IWebDriver driver, String name, Dictionary { enableJavaScript = (bool)options["enableJavaScript"]; } - domSnapshot = (String)jse.ExecuteScript(BuildSnapshotJS(enableJavaScript.ToString())); + domSnapshot = jse.ExecuteScript(BuildSnapshotJS(enableJavaScript.ToString())).ToString(); } catch (WebDriverException e) From 08f2f7dccffa71ef4cf111199d60f96515fd3e58 Mon Sep 17 00:00:00 2001 From: vvchens Date: Thu, 9 Feb 2023 12:41:18 -0500 Subject: [PATCH 5/5] correct typo --- percy-csharp-selenium/Percy.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/percy-csharp-selenium/Percy.cs b/percy-csharp-selenium/Percy.cs index dbcb9dc..9329da0 100644 --- a/percy-csharp-selenium/Percy.cs +++ b/percy-csharp-selenium/Percy.cs @@ -136,7 +136,7 @@ public void Snapshot(IWebDriver driver, String name, Dictionary { enableJavaScript = (bool)options["enableJavaScript"]; } - domSnapshot = jse.ExecuteScript(BuildSnapshotJS(enableJavaScript.ToString())).ToString(); + domSnapshot = (String)jse.ExecuteScript(BuildSnapshotJS(enableJavaScript.ToString())); } catch (WebDriverException e) @@ -272,7 +272,7 @@ private String BuildSnapshotJS(String enableJavaScript) { StringBuilder jsBuilder = new StringBuilder(); // the double {{ and }} are needed to escape the curly braces - jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0}, stringfy_response: true }})\n", enableJavaScript.ToLower())); + jsBuilder.Append(String.Format("return PercyDOM.serialize({{ enableJavaScript: {0}, stringify_response: true }})\n", enableJavaScript.ToLower())); return jsBuilder.ToString(); }