Fix for select fields

[iz-iznogood]

When using select on a breeze query, the result returns also the sequelize models (especially if we expand into some navigation property) and this creates serialization problems

I managed to overcome this issue by using the Model.get({ plain: true }) which returns simple javascript objects without the sequelize models and also with nested sub-objects / sub-arrays which IMHO maps better to what the client might expect

Proposed method change in SequelizeQuery.js

private _reshapeSelectResults(sqResults: CountModel | Model[]) {
    const options = {
        plain: true
    };
    if (this.entityQuery.inlineCountEnabled) {
        return {
            results: (sqResults as CountModel).rows.map(x => x.get(options)),
            inlineCount: (sqResults as CountModel).count
        };
    } else {
        return (sqResults as Model[]).map(x => x.get(options));
    }
}

It is tested and works well but it changes the semantics because now for nested properties the system returns

{
    "foo.bar": 1
}

and my code returns

{
    foo: {
         bar: 1
    }
}

But this allows us to handle nested arrays which did not work before

[steveschmitt]

Hmm. It makes sense, but as you say, it really depends upon what the client might expect.

[iz-iznogood]

As it is now, it breaks with errors on the JsonResultsAdapter (for nested entities) because the sequelize model is included in the results. This is what the Model.get(options) fixes, it removes the sequelize objects that don't make any sense to the breeze context.

Now the other issue with the sub-objects that are flattened, with arrays it does not work (also multiplies the rows), with 1-1 navigations (objects) it works but seems a bit unnatural. You have names like "foo.bar", ok it can work in some cases but it is not generic.

Maybe adding an option, something like "nestedSelects" could fix it for both cases.
But the error in the jsonAdapter should be fixed anyways

Thanks