Avoid inclusion of <windows.h>

[firegurafiku]

Briefly looking through the source code I've noticed that at least one its header file includes windows.h. This file has always been a nightmare as it spoils global namespace with lots of macro definitions with unprefixed names which are likely to clash. It's not the the way like modern C++ deals with things.

The only one way windows.h could be reliably hidden is putting it in a source file, not a header. I know that after this you cannot call the library header only, but to me this really makes sense for code sanity.

[BorisSchaeling]

Thank you! Nobody is currently actively working on the library. But I do appreciate tickets as all that collective knowledge should make it easier for someone to resume working on the library.

[firegurafiku]

Nobody is currently actively working on the library.

Sad to listen that. But AFAIK Boost.Process is scheduled for another formal review. Does it have all previous review issues fixed? Where I can find a list of problems revealed by the reviewers?

[BorisSchaeling]

Someone tried to clean up the review queue, and I agreed that the library should be removed from the queue (see http://article.gmane.org/gmane.comp.lib.boost.devel/258905). The reason is that the library has been waiting for a review for more than 2 years.