Merge pull request #38 from Block-Guard/feat/#33/news-api

[Refactor] 공공데이터 호출 방식 변경

Author: chaeyuuu

src/main/java/com/blockguard/server/infra/importer/FraudUrlImporter.java

@@ -18,6 +18,7 @@
 import java.nio.charset.StandardCharsets;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 
@@ -26,7 +27,7 @@
 @RequiredArgsConstructor
 public class FraudUrlImporter {
 
-    private static final int PER_PAGE = 50;
+    private static final int PER_PAGE = 300;
     private static final int MAX_PAGE = 1000;
     private static final int DELAY_BETWEEN_REQUESTS_MS = 200;
 
@@ -47,20 +48,18 @@ public class FraudUrlImporter {
     @Transactional
     public void syncFraudUrlsFromOpenApi() {
 
-        log.info("2024 버전 사기 URL 동기화 시작");
-        importFrom(apiUrl);
-
-/*        log.info("2023 버전 사기 URL 동기화 시작");
-        importFrom(apiUrlOld);*/
+  /*      log.info("2024 버전 사기 URL 동기화 시작");
+        importFrom(apiUrl);*/
 
+        log.info("2023 버전 사기 URL 동기화 시작");
+        importFrom(apiUrlOld);
     }
 
     private void importFrom(String baseUrl) {
         int page = 1;
         boolean hasNext = true;
 
         while (hasNext && page <= MAX_PAGE) {
-
             String encodedKey = URLEncoder.encode(serviceKey, StandardCharsets.UTF_8);
             String fullUrl = String.format("%s?page=%d&perPage=%d&serviceKey=%s",
                     baseUrl, page, PER_PAGE, encodedKey);
@@ -76,21 +75,26 @@ private void importFrom(String baseUrl) {
                 if (data == null || data.isEmpty()) {
                     hasNext = false;
                 } else {
+                    List<FraudUrl> fraudUrlsToSave = new ArrayList<>();
+
                     for (Map<String, Object> item : data) {
                         String detectedDateStr = (String) item.get("날짜");
                         String urlStr = (String) item.get("홈페이지주소");
 
                         if (urlStr == null || detectedDateStr == null) continue;
+                        if (fraudUrlRepository.existsByUrl(urlStr)) continue;
 
-                        if (!fraudUrlRepository.existsByUrl(urlStr)) {
-                            LocalDate detectedDate = LocalDate.parse(detectedDateStr);
-                            fraudUrlRepository.save(FraudUrl.builder()
-                                    .url(urlStr)
-                                    .detectedDate(detectedDate)
-                                    .lastCheckedAt(LocalDateTime.now())
-                                    .build());
-                        }
+                        LocalDate detectedDate = LocalDate.parse(detectedDateStr);
+                        FraudUrl fraudUrl = FraudUrl.builder()
+                                .url(urlStr)
+                                .detectedDate(detectedDate)
+                                .lastCheckedAt(LocalDateTime.now())
+                                .build();
+
+                        fraudUrlsToSave.add(fraudUrl);
                     }
+
+                    fraudUrlRepository.saveAll(fraudUrlsToSave);
                     page++;
                 }
 
@@ -106,5 +110,6 @@ private void importFrom(String baseUrl) {
                 throw new BusinessExceptionHandler(ErrorCode.FAIL_IMPORT_OPEN_API);
             }
         }
+        log.info("전체 저장 완료");
     }
 }