Skip to content

Commit f81e066

Browse files
authored
Merge pull request #145 from kjoon418/main
feat: 할 일 제출 판단 기준을 다른 경우와 통일
2 parents 1210956 + 6818613 commit f81e066

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/main/kotlin/goodspace/bllsoneshot/mentor/service/MentorDashboardService.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ class MentorDashboardService(
8080

8181
val menteeIds = mentees.map { it.id!! }
8282

83-
val unsubmittedMenteeIds = taskRepository
84-
.findMenteeIdsWithUnsubmittedTasks(menteeIds, date)
83+
val incompletedMenteeIds = taskRepository
84+
.findMenteeIdsWithIncompletedTasks(menteeIds, date)
8585
.toSet()
8686

8787
val recentTaskByMenteeId = taskRepository
@@ -98,7 +98,7 @@ class MentorDashboardService(
9898
subjects = mentee.subjects.map { it.subject },
9999
recentTaskDate = recentTask?.date,
100100
recentTaskName = recentTask?.name,
101-
submitted = mentee.id!! !in unsubmittedMenteeIds
101+
submitted = mentee.id!! !in incompletedMenteeIds
102102
)
103103
}
104104

src/main/kotlin/goodspace/bllsoneshot/repository/task/TaskRepository.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,14 +150,13 @@ interface TaskRepository : JpaRepository<Task, Long> {
150150
"""
151151
SELECT DISTINCT t.mentee.id
152152
FROM Task t
153-
LEFT JOIN t.proofShots ps
154153
WHERE t.mentee.id IN :menteeIds
155154
AND t.date = :date
156155
AND t.isResource = false
157-
AND ps.id IS NULL
156+
AND t.completed = false
158157
"""
159158
)
160-
fun findMenteeIdsWithUnsubmittedTasks(menteeIds: List<Long>, date: LocalDate): List<Long>
159+
fun findMenteeIdsWithIncompletedTasks(menteeIds: List<Long>, date: LocalDate): List<Long>
161160

162161
@Query(
163162
"""

0 commit comments

Comments
 (0)