From c05c1d2b66095e2c566033b7801741e92c9cf02e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E6=A2=81=E6=99=93=E7=94=9F?= Date: Sun, 26 Nov 2023 17:18:33 +0800 Subject: [PATCH] feat: add ValidateFailed error --- .../context/workspace/domain/workflow/event_handlers.go | 2 +- pkg/errors/code.go | 1 + pkg/errors/errors.go | 8 ++++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/internal/context/workspace/domain/workflow/event_handlers.go b/internal/context/workspace/domain/workflow/event_handlers.go index 9023c58..cd0fbd0 100644 --- a/internal/context/workspace/domain/workflow/event_handlers.go +++ b/internal/context/workspace/domain/workflow/event_handlers.go @@ -178,7 +178,7 @@ func (h *WorkflowVersionAddedHandler) validateWorkflowFiles(ctx context.Context, validateResult, err := exec.Exec(ctx, CommandExecuteTimeout, "java", "-jar", h.womtoolPath, "validate", path.Join(baseDir, mainWorkflowPath), "-l") if err != nil { applog.Errorw("fail to validate workflow", "err", err, "result", string(validateResult)) - return apperrors.NewInternalError(fmt.Errorf("validate workflow failed")) + return apperrors.NewValidateFailedError(fmt.Errorf("please check if there are any syntax errors in your workflow")) } validateResultLines := strings.Split(string(validateResult), "\n") applog.Infow("validate result", "result", validateResultLines) diff --git a/pkg/errors/code.go b/pkg/errors/code.go index 7cf561e..69e4baa 100644 --- a/pkg/errors/code.go +++ b/pkg/errors/code.go @@ -26,6 +26,7 @@ const ( InternalCode TemporaryDisabledCode TimeoutCode + ValidateFailedCode ) // hertz code. diff --git a/pkg/errors/errors.go b/pkg/errors/errors.go index 4f94b5a..a307af2 100644 --- a/pkg/errors/errors.go +++ b/pkg/errors/errors.go @@ -86,6 +86,14 @@ func NewInternalError(err error) *AppError { } } +func NewValidateFailedError(err error) *AppError { + return &AppError{ + Code: ValidateFailedCode, + Message: "validate failed", + Inner: err, + } +} + func NewHertzBindError(err error) *AppError { return &AppError{ Code: BindErrorCode,