Skip to content

feat: store workflowVersionID into submission table #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liang09255 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: store workflowVersionID into submission table #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6799587
feat: store workflowVersionID into submission table
liang09255 Nov 26, 2023
d9480d8
add workflowVersionID in RunConfig
liang09255 Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/context/submission/domain/submission/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ type RunConfig struct {
MainWorkflowFilePath string
WorkflowEngineParameters map[string]interface{}
Version string
WorkflowVersionID string
}

func NewEventCreateRuns(workspaceID, submissionID, submissionType string, inputs, outputs map[string]interface{}, dataModelID *string, DataModelRowIDs []string, runConfig *RunConfig) *EventCreateRuns {
Expand Down
9 changes: 7 additions & 2 deletions internal/context/submission/domain/submission/event_create_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,16 @@ func (h *CreateHandler) Handle(ctx context.Context, event *CreateEvent) (err err
if err != nil {
return err
}
// todo we should store the data model & workflow used in submission
createRunEvent, err := h.genCreateRunEvent(ctx, event, sub)
if err != nil {
return err
}

// write workflowVersionID into submission table
sub.WorkflowVersionID = createRunEvent.RunConfig.WorkflowVersionID
err = h.repository.Save(ctx, sub)
if err != nil {
return err
}
return h.eventbus.Publish(ctx, createRunEvent)
}

Expand Down Expand Up @@ -71,6 +75,7 @@ func (h *CreateHandler) genCreateRunEvent(ctx context.Context, event *CreateEven
WorkflowContents: files,
WorkflowEngineParameters: workflowEngineParameters,
Version: getWorkflowVersionResp.Version.LanguageVersion,
WorkflowVersionID: getWorkflowVersionResp.Version.Id,
}), nil

}
Expand Down