Skip to content

Commit 71f285f

Browse files
authored
Merge pull request #41 from BeyteFlow/copilot/sub-pr-40
Fix invalid semantic HTML: `<button>` nested inside `<a>` in not-found.tsx
2 parents f003a24 + 8dd5826 commit 71f285f

3 files changed

Lines changed: 33 additions & 22 deletions

File tree

package-lock.json

Lines changed: 24 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"eslint": "^9",
3434
"eslint-config-next": "16.1.6",
3535
"tailwindcss": "^4",
36-
"typescript": "^5",
36+
"typescript": "5.9.3",
3737
"vitest": "^4.0.18"
3838
}
3939
}

src/app/not-found.tsx

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,16 @@ export default function NotFound() {
3838

3939
{/* CTA Buttons */}
4040
<div className="flex flex-col sm:flex-row items-center justify-center gap-4 mb-20 animate-in fade-in slide-in-from-bottom-6 duration-1000">
41-
<Link href="/">
42-
<Button
43-
variant="primary"
44-
className="w-full sm:w-auto px-10 py-4 text-lg shadow-xl shadow-white/5"
45-
>
41+
<Button
42+
asChild
43+
variant="primary"
44+
className="w-full sm:w-auto px-10 py-4 text-lg shadow-xl shadow-white/5"
45+
>
46+
<Link href="/">
4647
<Home size={20} />
4748
Back to Safety
48-
</Button>
49-
</Link>
49+
</Link>
50+
</Button>
5051

5152
<Button
5253
variant="outline"

0 commit comments

Comments
 (0)