Skip to content

download breaks when using a relative path instead of a full url #357

@mprast

Description

@mprast

🐞 Describe the bug
As described in the docs, there are two ways to specify a space for spaces-cli to use when downloading a file. One is to use the -s command line option, and the other is to include it in the full download file url. The first path currently breaks with the error message 'Cannot read properties of null (reading 'includes')' . As far as I can tell this is coming from this line. Specifying a relative path instead of a full url causes the hostname to be undefined, which ends up blowing things up. The docs themselves provide a download example that uses a relative path, so I was expecting that to be supported.

📚 To Reproduce

try downloading just using a relative path

💡 Expected behavior

I should be able to use a relative path

🖼️ Screenshots

If applicable, add screenshots to help explain your problem.

⚙️ Environment

  • Version: 1.0.41
  • OS: fedora
  • Shell bash

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions