`newickstring` output generates a rooted tree

[cvigilv]

Hi! Just wanted to open this bug report as I'm trying to use the Newick strings generated from this package in an external program and this throws a warning that the trees are rooted, when NJ is an algorithm to generate unrooted trees. Unsure if the package was designed to enforce rooting or not. I'm currently looking around the codebase to see if there is any mistake that generates this, but in the mean time I would like to know if this is by design or an error.

Thanks in advance

[BenjaminDoran]

It's rooted in the sense that the 'root' is the last pair of clades joined by the NJ algorithm. It's completely true that that 'root' is not necessarily biologically meaningful.

For my purposes that was fine, but it is probably a footgun waiting for users. I would accept a pull request that updates [src/newickstring.jl] to output unrooted or rooted tree formats.

I would want to keep both output formats because there are other programs that only accept rooted trees.