Add background coloring to nodes

[cvigilv]

Description

I'm looking to produce something like the following:

Currently, one can use the current plot and use Makie.voronoi to achieve something similar, but it would be nice to have an option in the Makie recipe to directly map the categories.

Validation and testing

No response

Motivation

No response

Target audience

No response

Can you help?

Currently implementing this in my local version of the package, will push work to a pull request in the coming days

[BenjaminDoran]

I think this is a great feature

It may be worth developing it as a new recipe rather than an argument to the current treeplot layer, just as band and lines are separate recipes in Makie. Separating these will also help with keeping the keyword options specific to each layer.

You may also get away with drawing a simpler poly rectangle with enough points on the vertical edges so that on the polar axis it looks curved.

I look forward to the pull request

[BenjaminDoran]

I would also look at the geom_hilight from ggtree, for inspiration on what arguments may be needed for the api of the plotting function, and maybe how it's implemented.

[cvigilv]

I didn't know about geom_hilight, seems like a nice way of tackling this problem. I'll give it a look and come back to you

[cvigilv]

Hi again, I implemented a recipe (not really, but will do as soon as I get you opinion) that does something similar to geom_hilight:

Code:

begin
    # Setup
    nodes_to_highlight = [tree, (:a, :b), (:d, :e)]
    padding = 0.2
    # Plot
    f = Figure()
    ax = Axis(f[1, 1])
    for (node, color, padding) in zip(nodes_to_highlight, [:gainsboro, :red, :blue], [0.2, 0.1, 0.1])
        @show xmin = first(nodecoords[argmin(n -> first(nodecoords[n]), PreOrderDFS(node))]) - padding
        @show xmax = first(nodecoords[argmax(n -> first(nodecoords[n]), PreOrderDFS(node))]) + padding
        @show ymin = last(nodecoords[argmin(n -> last(nodecoords[n]), PreOrderDFS(node))]) - padding
        @show ymax = last(nodecoords[argmax(n -> last(nodecoords[n]), PreOrderDFS(node))]) + padding
        poly!(
            ax,
            Point2f[(xmin, ymin), (xmin, ymax), (xmax, ymax), (xmax, ymin)],
            color=(color, 0.5),
        )
    end
    treeplot!(ax, tree, usemaxdepth=false)
    hideydecorations!(ax)
    hidespines!(ax)
    f
end

[cvigilv]

The PolarAxis version will take a little longer because there is a bug with the poly! function in CairoMakie. I'm implementing my own version of that function to use it until that bug if fixed upstream.

I'll get back with the example as soon as I have it

[BenjaminDoran]

Ok, I think the general approach looks good, I'll be mostly away from my computer until next week, but you can submit a draft pull request whenever you have an initial recipe. And we can continue working on it there, until it is ready to merge into main.

Two other things,

• can you link to the makie issue here
• have you tried adding more coordinate tuples between your 1st and 2nd, and 3rd and 4th points to interpolate between y coords? Similar to how I made the branch segments.

I'll take a closer look when I'm back next week

[cvigilv]

Tested adding more segments as you do it, but unfortunately the poly function on CairoMakie doesn't transform the coordinates correctly so I have to do it manually and haven't been able to achieve the desired output. I'll push the implementation on the coming days to see if you can check if the logic is correct.

[BenjaminDoran]

Capability added with PR #25