[Bug] Unable to use `treelabels`

[cvigilv]

Description

Hi! I'm trying to update old drawing scripts to the new version of the package, but I haven't been able to get it to work due to issues with the treelabel function. Have tested both plotting directly with treeplot and doing it over a figure's axis.

Package Version

v0.2.0

Julia Version

1.12.4

Reproduction steps

begin
	ngram_S = similarity(ngrams)
	ngram_tree = newickstring(regNJ(1 .- ngram_S), labels) |> readnw |> ladderize
	
	fig = Figure()
	ax = PolarAxis(fig[1, 1], rautolimitmargin = (0.0, 0.1))
	hidedecorations!(ax)
	hidespines!(ax)
	
	t = treeplot!(ax, ngram_tree)
	treelabels!(t)
	fig
end

Relevant log output

Failed to resolve arg1:

[ComputeEdge] arg1 = compute_identity((expandedbranchsegments, ), changed, cached)
  @ /Users/carlos/.julia/packages/ComputePipeline/soTSa/src/ComputePipeline.jl:737

[ComputeEdge] expandedbranchsegments = (::MapFunctionWrapper(#18))((branchsegments, ), changed, cached)

  @ /Users/carlos/.julia/packages/BasicTreePlots/5T2Fo/ext/BasicTreePlotsMakieExt.jl:263

[ComputeEdge] nodepoints, orderedpoints, branchsegments, maxtreedepth, nleaves = (::MapFunctionWrapper(#3))((tree, showroot, layoutstyle, leafoffset, branchstyle, branchpointresolution, openangle, usemaxdepth, orientation, maxdepthoffset, transform_func, ), changed, cached)

  @ unknown method location

  with edge inputs:

    tree = ((Tub2Fbeta:0.3766507,Tub2Falpha:0.3765493):0.02576838,((Tub2Cf:0.4223956,(Tub2Bf:0.4078805,Tub2Be:0.4167195):0.009004425):0.005363245,((Tub2Ch:0.3883559,Tub2Cg:0.3908441):0.02968506,((Tub2Dbeta:0.3863046,Tub2Dalpha:0.3850954):0.03724172,((((Tub2Mbeta:0.3781165,Tub2Malpha:0.3846835):0.06756984,((Tub2Lbeta:0.4005761,Tub2Lalpha:0.3970239):0.04594274,(Tub2Kbeta:0.3703922,Tub2Kalpha:0.3702078):0.06135726):0.009780162):0.004678388,(((Tub2Jbeta:0.3771132,Tub2Jalpha:0.3786868):0.02958589,(Tub2Ebeta:0.3784106,Tub2Ealpha:0.3851894):0.02321411):0.008086232,((Tub2Gbeta:0.3826601,Tub2Galpha:0.3883399):0.03237006,((Tub2Ibeta:0.3733337,Tub2Ialpha:0.3780663):0.01440076,(Tub2Hbeta:0.3731362,Tub2Halpha:0.3754638):0.01339924):0.02357994):0.001288768):0.01106536):0.003010016,(((Tub2Ag:0.3533938,((Tub2Da:0.2944735,(Tub2Db:0.285372,Tub2D:0.274828):0.008526504):0.02497674,(Tub2Ce:0.3111764,(Tub2Ac:0.2425869,(Tub2Ad:0.2271804,((Tub2Cb:0.1864276,(Tub2Cd:0.1939416,(Tub2Cc:0.15598,Tub2Ca:0.16482):0.01985839):0.004672434):0.02258692,((Tub2Ab:0.1509354,Tub2Aa:0.1510646):0.04739554,(Tub2Bd:0.1803098,(Tub2Bc:0.1628896,Tub2Bb:0.1633104):0.0114902):0.02305446):0.01195683):0.01151025):0.01510059):0.0424736):0.01668889):0.01955618):0.01546543,((Tub2Cbeta:0.316047,(Tub2Abeta:0.3109971,(Tub2Calpha:0.3004347,Tub2Aalpha:0.2993653):0.009602851):0.005352975):0.05761927,((Tub2B:0.413218,(Tub2:0.3470789,(Tub2Beta:0.2862057,Tub2Alpha:0.2797943):0.1309211):0.01278201):0.03111525,(Tub2Ba:0.3798856,((Tub2Ah:0.3585666,(Tub2Af:0.338991,Tub2Ae:0.341209):0.02263343):0.01621425,(Tub2H:0.3796202,(Tub2X:0.3757025,(Tub2G:0.3315088,(Tub2C:0.3023347,(Tub2A:0.2792743,(Tub2F:0.2394015,Tub2E:0.2281985):0.0339257):0.02236534):0.01684121):0.01974751):0.0003673023):0.01698575):0.006789446):0.005148814):0.002645578):0.006901659):0.008049531,((Tub2Bbeta:0.3360745,Tub2Balpha:0.3423255):0.0804048,(((Tub2Ib:0.4110465,Tub2Ia:0.4153535):0.04252695,(Tub2Dc:0.4269746,(Tub2W:0.4675188,(Tub2Z:0.4045526,Tub2Y:0.3816474):0.02568125):0.007025446):0.007023052):0.002400128,((Tub2L:0.4460712,(Tub2J:0.4384143,(Tub2N:0.3739128,((Tub2P:0.3689449,Tub2O:0.3714551):0.005025243,(Tub2Q:0.3716777,(Tub2R:0.3725011,(Tub2M:0.3681827,Tub2I:0.3506173):0.00489885):0.001422253):0.003124757):0.001612165):0.03407323):0.01282881):0.01735106,(Tub2K:0.4747195,((Tub5:0.489031,((outgroup:0.4976715,((Tub4B:0.4022217,Tub4A:0.4027783):0.09226008,(Tub6:0.488595,Tub4:0.486405):0.007039922):0.002778521):0.001652261,((Tub3Beta:0.3363554,Tub3Alpha:0.3326446):0.1101457,(Tub3:0.4262743,((Tub3C:0.3969166,Tub3B:0.3920834):0.008408767,(Tub3Aa:0.3815835,Tub3A:0.3762165):0.01909123):0.02737573):0.01650427):0.04635711):0.003139333):0.002232064,((Tub1Mbeta:0.3777973,Tub1Malpha:0.3774027):0.1011592,((Tub1Eb:0.454872,Tub1Ea:0.455528):0.02195976,((Tub1Beta:0.3919925,Tub1Alpha:0.3908075):0.08222303,((Tub1P:0.4516425,Tub1O:0.4561575):0.01023493,((Tub1S:0.4451136,((Tub1Ha:0.4163036,(Tub1Hc:0.3892129,Tub1Hb:0.3877871):0.03469636):0.02407353,(((Tub1T:0.4315903,Tub1R:0.4252097):0.001078531,((Tub1Kb:0.3826086,Tub1Ka:0.3963914):0.02562029,(Tub1Cb:0.3893022,Tub1Ca:0.3906978):0.02857971):0.01422147):0.004457981,(Tub1H:0.4179806,(Tub1Q:0.4141768,(Tub1:0.4069208,((Tub1Gb:0.3607589,Tub1Ga:0.3620411):0.03510601,(Tub1I:0.3941929,((Tub1N:0.3460039,Tub1M:0.3565961):0.02765002,(Tub1A:0.3642214,(Tub1E:0.3499301,(Tub1B:0.3397471,((Tub1F:0.313046,(Tub1Fb:0.2933335,Tub1Fa:0.2966665):0.03055401):0.01827652,(Tub1C:0.3221151,(Tub1J:0.3111806,(Tub1L:0.283975,(Tub1G:0.2492562,Tub1D:0.2503438):0.023025):0.01761937):0.01163485):0.01154848):0.006302885):0.002557445):0.01485983):0.009009356):0.01100947):0.004290671):0.01323707):0.004964519):0.004983882):0.00586466):0.00764632):0.008128664):0.007988932,(Tub1Be:0.4539376,(Tub1K:0.4185561,((Tub1Ibeta:0.3782072,Tub1Ialpha:0.3833928):0.04421791,((Tub1Fbeta:0.3777893,Tub1Falpha:0.3814107):0.04048895,(((Tub1Jbeta:0.4002409,((Tub1Lbeta:0.3784777,Tub1Lalpha:0.3791223):0.01586089,(Tub1Jalpha:0.3851498,(Tub1Hbeta:0.3701256,Tub1Halpha:0.3698744):0.01405024):0.008989113):0.005884142):0.01756474,((Tub1Dbeta:0.3697655,Tub1Dalpha:0.3722345):0.03722241,((Tub1Gbeta:0.3736378,Tub1Galpha:0.3735622):0.02599463,(Tub1Ebeta:0.3745847,Tub1Ealpha:0.3760153):0.02030537):0.00772759):0.009010257):0.003883254,((Tub1Ah:0.400159,Tub1Ag:0.398441):0.01105077,(((Tub1Cbeta:0.373052,Tub1Calpha:0.376148):0.0146497,(Tub1Bbeta:0.3823954,Tub1Balpha:0.3826046):0.007050296):0.007857206,((Tub1Bd:0.290565,(Tub1Bc:0.2119845,(Tub1Bb:0.1935244,Tub1Ba:0.1940756):0.01641554):0.05023502):0.07336142,(Tub1Ae:0.3272829,(Tub1Af:0.3096318,(Tub1Ad:0.233912,(Tub1Ac:0.1331365,(Tub1Ab:0.1145913,Tub1Aa:0.1126087):0.01626352):0.08698805):0.05176818):0.0167421):0.02957139):0.0277092):0.01177657):0.01169736):0.002028166):0.001000842):0.002956691):0.0255046):0.009015508):0.006363185):0.01023507):0.001426994):0.006789423):0.0153645):0.02402046):0.008155825):0.01267634):0.01233376):0.007129871):0.00417422):0.003006939):0.004086632):0.001064935):0.02576838);

    showroot = false

    layoutstyle = :dendrogram

    leafoffset = 0

    branchstyle = :square

    branchpointresolution = 25

    openangle = 0

    usemaxdepth = false

    orientation = :right

    maxdepthoffset = 0.0f0

    transform_func = Makie.Polar(true, true, 0.0, 1, 0.0)

Triggered by update of:

  openangle, showroot, branchpointresolution, orientation, usemaxdepth, leafoffset, branchstyle, maxdepthoffset, layoutstyle, arg1 or transform_func

Due to ERROR: ArgumentError: map! requires at least one "source" argument

Operating System

Mac

[cvigilv]

Doens't work with the example of the documentation either:

let
	tree = ((:a, :b), (:c, (:d, :e)))
	fig = Figure()
	ax = PolarAxis(fig[1, 1], rautolimitmargin = (0.0, 0.1))
	hidedecorations!(ax)
	hidespines!(ax)
	tp = treeplot!(tree; branchcolor = :orange)
	treelabels!(tp; fontsize = 20)
	fig
end

error message:

Failed to resolve arg1:

[ComputeEdge] arg1 = compute_identity((expandedbranchsegments, ), changed, cached)

  @ /Users/carlos/.julia/packages/ComputePipeline/soTSa/src/ComputePipeline.jl:737

[ComputeEdge] expandedbranchsegments = (::MapFunctionWrapper(#18))((branchsegments, ), changed, cached)

  @ /Users/carlos/.julia/packages/BasicTreePlots/5T2Fo/ext/BasicTreePlotsMakieExt.jl:263

[ComputeEdge] nodepoints, orderedpoints, branchsegments, maxtreedepth, nleaves = (::MapFunctionWrapper(#3))((tree, showroot, layoutstyle, leafoffset, branchstyle, branchpointresolution, openangle, usemaxdepth, orientation, maxdepthoffset, transform_func, ), changed, cached)

  @ unknown method location

  with edge inputs:

    tree = ((:a, :b), (:c, (:d, :e)))

    showroot = false

    layoutstyle = :dendrogram

    leafoffset = 0

    branchstyle = :square

    branchpointresolution = 25

    openangle = 0

    usemaxdepth = false

    orientation = :right

    maxdepthoffset = 0.0f0

    transform_func = Makie.Polar(true, true, 0.0, 1, 0.0)

Triggered by update of:

  openangle, showroot, branchpointresolution, orientation, usemaxdepth, leafoffset, branchstyle, maxdepthoffset, layoutstyle, arg1 or transform_func

Due to ERROR: ArgumentError: map! requires at least one "source" argument
Stack trace

Here is what happened, the most recent locations are first:

    map!(::BasicTreePlotsMakieExt.var"#16#34"{…}, ::Vector{…}) [...show types...](http://localhost:1234/edit?id=edb37606-f847-11f0-2b77-4b12d54f9680#)
    from 
    [julia → abstractarray.jl:3472](https://github.com/JuliaLang/julia/tree/cf1da5e20e394640768848e069337d3bca135bd1/base/abstractarray.jl#L3471)

BTW, I'm testing this within Pluto, which may be relevant.

[cvigilv]

It seems that the documentation is wrong; I just used the example in the docstrings, and it's correct. There, it uses (based on the last example) tp.nodepositions as an input of the treelabel function. Either something weird is going on, or the documentation is wrong.

[BenjaminDoran]

That is weird, I just tried it in new environment and the example you provided works for me both in pluto and in vscode.

[BenjaminDoran]

Could you share the environment status you're working with?

[cvigilv]

Status `~/.julia/scratchspaces/c3e4b0f8-55cb-11ea-2926-15256bba5781/pkg_envs/env_nlqzppzxqx/Project.toml`
  [1520ce14] AbstractTrees v0.4.5
  [523fa316] BasicTreePlots v0.2.0
  [13f3f980] CairoMakie v0.15.8
  [8be319e6] Chain v1.0.0
  [35d6a980] ColorSchemes v3.31.0
  [5ae59095] Colors v0.13.1
  [f88b31d2] NCBITaxonomy v0.4.1
  [b0a14db8] NewickTree v0.4.0
  [44cfe95a] Pkg v1.11.0

[cvigilv]

It seems to be something with PolarAxis, because with the normal Axis I have mo problem

[cvigilv]

Any updates on this?

[cvigilv]

This only happens in Julia v1.11, just updated to 1.12 and I have no problems. Maybe worth looking at

[BenjaminDoran]

cool, I may have some time in the next couple of weeks. I'll see if I can track down the issue