Skip to content

Commit 4eda700

Browse files
committed
fix: Ticketbai::batuzIncomeTaxes should be able to return null values
1 parent 4f850a2 commit 4eda700

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/Barnetik/Tbai/TicketBai.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ public function addBatuzIncomeTaxes(Collection $incomeTaxCollection): self
204204
return $this;
205205
}
206206

207-
public function batuzIncomeTaxes(): Collection
207+
public function batuzIncomeTaxes(): ?Collection
208208
{
209209
return $this->batuzIncomeTaxCollection;
210210
}

tests/Barnetik/Tbai/TicketBaiTest.php

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ public function test_TicketBai_issuer_name_allows_ampersands(): void
222222
public function test_gh29_TicketBai_sends_operation_date_element(): void
223223
{
224224
$nif = $_ENV['TBAI_ARABA_ISSUER_NIF'];
225-
$issuer = 'Test with & on issuer name';
225+
$issuer = $_ENV['TBAI_ARABA_ISSUER_NAME'];
226226
$license = $_ENV['TBAI_ARABA_APP_LICENSE'];
227227
$developer = $_ENV['TBAI_ARABA_APP_DEVELOPER_NIF'];
228228
$appName = $_ENV['TBAI_ARABA_APP_NAME'];
@@ -245,7 +245,7 @@ public function test_gh29_TicketBai_sends_operation_date_element(): void
245245
public function test_gh47_foreign_recipient_ticketbai_can_be_generated_from_xml(): void
246246
{
247247
$nif = $_ENV['TBAI_ARABA_ISSUER_NIF'];
248-
$issuer = 'Test with & on issuer name';
248+
$issuer = $_ENV['TBAI_ARABA_ISSUER_NAME'];
249249
$license = $_ENV['TBAI_ARABA_APP_LICENSE'];
250250
$developer = $_ENV['TBAI_ARABA_APP_DEVELOPER_NIF'];
251251
$appName = $_ENV['TBAI_ARABA_APP_NAME'];
@@ -303,7 +303,7 @@ public function test_gh47_foreign_recipient_ticketbai_can_be_generated_from_xml(
303303
public function test_gh48_Greek_Vatid_prefix_EL_instead_of_GR(): void
304304
{
305305
$nif = $_ENV['TBAI_ARABA_ISSUER_NIF'];
306-
$issuer = 'Test with & on issuer name';
306+
$issuer = $_ENV['TBAI_ARABA_ISSUER_NAME'];
307307
$license = $_ENV['TBAI_ARABA_APP_LICENSE'];
308308
$developer = $_ENV['TBAI_ARABA_APP_DEVELOPER_NIF'];
309309
$appName = $_ENV['TBAI_ARABA_APP_NAME'];
@@ -336,4 +336,12 @@ public function test_gh48_Greek_Vatid_prefix_EL_instead_of_GR(): void
336336
$finalVatId = $xpath->evaluate('string(/T:TicketBai/Sujetos/Destinatarios/IDDestinatario/IDOtro/ID)');
337337
$this->assertEquals('IE00000000T', $finalVatId);
338338
}
339+
340+
public function test_gh55_TicketBai_should_allow_return_of_null_batuzIncomeTaxCollection(): void
341+
{
342+
$ticketbai = $this->ticketBaiMother->createBizkaiaTicketBaiSelfEmployed();
343+
$this->assertNull($ticketbai->batuzIncomeTaxes());
344+
}
345+
346+
339347
}

0 commit comments

Comments
 (0)