Skip to content

[BUG]: Wrong logic of hmrR_PruneChannels.m for excluding both wavelengths of same channel. #200

@BAK262

Description

@BAK262

Version of Homer3 you are using

Homer3-1.80.2

Description of the issue

Issue 1:
In the lines 89-111, the variable idxsExcl records source-detector pairs where a time series from arbitrary wavelength fails to pass the threshold. However, the exclusion operation (aka line 110 chanList(lst(idxsExcl)) = 0) happens for each loop. This will cause situations that (1) when the time series of 1st wavelength fails to be included (and 2nd not), both series will be pruned ultimately, (2) however, when the time series of 2nd wavelength fails (and 1st not), only the 2nd series will be pruned -- which probably leads a misinterpretation for the concentration data computed from only-one-wavelength source-detecter pairs.

Issue 2:
In the lines 115-126, the ii variable is definitely equal to nLambda. What information could it convey to users?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions