[Feature request] Allow veins to be finite

[mappleaf]

Must be configurable. Central vein blocks will have bigger ore yield value and last longer. Maybe block values better to be written in separate data file inside of world folder, because blockentities is laggy enough to be a problem. Mining depletes remaining value, and if it reaches zero - block will be removed.
Maybe you can also make some kind of mechanic to reduce value depletion, but it shouldn't be just tier-based.

[BMasta]

I will consider it.

[sleepy-evelyn]

There are plenty of ways you could do this. Different types of drill heads, attachments could increase or decrease the rate of mining. Removing vein blocks shouldn't be that hard because you can store the locations of each in blockpos integer format within nbt so you only have to pick out a random value every time you deplete a new ore block. This also works for multiple drills as well.

You could also define a vein multiplier in a config. Say for e.g. each vein block is worth x10 an ordinary block and so yields x10 the amount of regular resources. This could easily be configurable and give people control over how much a larger vein yields.

This is especially important because on a large server yields can be uncontrollably large. We tested using https://modrinth.com/project/7voFu8fj which seems similar and you could get up to 100k iron blocks with a good setup for example.

[BMasta]

Took more work than expected, but it is now implemented in the dev branch.

There is now a server config option infiniteDeposits, that is set to true by default.
When it's false, the new properties in the mining recipe take effect:

{
  "type": "create_rns:mining",
  "deposit_block": "create_rns:copper_deposit_block",
  "tier": 1,
  // When this property isn't defined, the deposit is considered infinite (even with finite deposits in the config)
  "durability": {
    // Defines the maximum number of uses at the "core" of a deposit (i.e. the deepest block in a vein). Depth is only counted horizontally.
    "core": 200000,
    // Defines the minimum number of uses at the "edge" (the outer-most block in a vein).
    "edge": 75000,
    // Defines what percentage of the average value at each depth can the number of uses fluctuate between.
    // Still, the number is guaranteed to be within the range [edge, core].
    "random_spread": 0.2
  },
  // When a deposit is exhausted, it will replace itself with the block defined here. If absent, replaces with air.
  "replace_when_depleted": "create_rns:depleted_deposit_block",
  "yield": [
    {
      "item": "create_rns:impure_copper_ore",
      "chance_weight": 1
    }
  ]
}

Deposit durability/uses is not calculated until a miner that can mine it is placed on the vein. Then, the whole vein is computed at once.

The miner will show cumulative remaining uses in its mining area:

I also added a Jade plugin (1.21.1 only) to show uses for individual deposit blocks:

[BMasta]

And yes, deposit blocks do not have block entities. The info about uses for each block is stored in a level data attachment. This also unfortunately means that if chunks are regenerated for an existing world, there might be some stale values. I am planning to add commands to manually remedy that.

[sleepy-evelyn]

And yes, deposit blocks do not have block entities. The info about uses for each block is stored in a level data attachment. This also unfortunately means that if chunks are regenerated for an existing world, there might be some stale values. I am planning to add commands to manually remedy that.

Thats the best approach honestly. Chunk regeneration is rare but is a good consideration.
This is brilliant though. Thank you <3.