-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
area: ci/cdGitHub Actions workflows and release pipelines.GitHub Actions workflows and release pipelines.area: cliCommand-line interface, arguments, and output formatting.Command-line interface, arguments, and output formatting.bugSomething isn't working (e.g., crashes, logical errors).Something isn't working (e.g., crashes, logical errors).priority: lowNice to have; can wait until later.Nice to have; can wait until later.
Description
Problem
When amdb encounters a critical error (e.g., missing database, parsing failure), it logs the error using tracing::error! but still exits with a successful 0 exit code. This breaks automated pipelines (like GitHub Actions), as they cannot detect if the amdb process actually failed.
Proposed Solution
- Update
src/main.rsto appropriately handleErrresults from core commands. - Ensure the application calls
std::process::exit(1)(or properly bubbles upanyhow::Resulttomainso the OS registers it as a failure) when an unrecoverable error occurs.
Definition of Done
- Failing commands (e.g., running
amdb generatewithout runninginitfirst) exit with code1. - Successful commands exit with code
0. - Verified that a simple bash script can catch the failure using
$?.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: ci/cdGitHub Actions workflows and release pipelines.GitHub Actions workflows and release pipelines.area: cliCommand-line interface, arguments, and output formatting.Command-line interface, arguments, and output formatting.bugSomething isn't working (e.g., crashes, logical errors).Something isn't working (e.g., crashes, logical errors).priority: lowNice to have; can wait until later.Nice to have; can wait until later.