Skip to content

Commit 330e4cd

Browse files
ImTotemclaude
andcommitted
fix(lint): resolve pyright type errors in PG migration
- shorten/service.py: update type hints to PgLinkRepository/PgMemberRepository - sync/router.py: use `in` check instead of truthy on Table|None - sync/seed.py: use postgresql.insert for on_conflict_do_nothing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 82b13d9 commit 330e4cd

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/bcsd_api/shorten/service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
from bcsd_api.filter.base import PagedResponse, apply_filter
88
from bcsd_api.filter.links import LinkFilter
99
from bcsd_api.id_gen import generate_id
10-
from bcsd_api.member.repository import MemberRepository
10+
from bcsd_api.member.pg_repository import PgMemberRepository as MemberRepository
1111
from bcsd_api.timezone import KST
1212

13-
from .repository import LinkRepository
13+
from .pg_repository import PgLinkRepository as LinkRepository
1414
from .schema import (
1515
CreateRequest,
1616
CreatorOption,

src/bcsd_api/sync/router.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ def dump_table(
4949
x_sync_token: str = Header(...),
5050
) -> list[dict]:
5151
_verify_token(x_sync_token, settings.sync_token)
52-
table = _TABLES.get(table_name)
53-
if not table:
52+
if table_name not in _TABLES:
5453
raise NotFound(f"table '{table_name}' not found")
54+
table = _TABLES[table_name]
5555
rows = conn.execute(select(table))
5656
return [row._asdict() for row in rows]
5757

src/bcsd_api/sync/seed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import logging
22

3-
from sqlalchemy import insert
3+
from sqlalchemy.dialects.postgresql import insert
44

55
from bcsd_api.config import Settings
66
from bcsd_api.database import create_engine

0 commit comments

Comments
 (0)