From 08ec663f724dfd82ff2ecd24cad2cd0e2dc72fc2 Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Fri, 20 Jun 2025 10:52:21 +0200 Subject: [PATCH 1/4] ci: Run unit and integration tests on all supported os/arch combinations This is good practice and also helps prevent regressions of #190 --- .github/workflows/integration-tests.yml | 11 ++++++++++- .github/workflows/unit-tests.yml | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 93926128..0e213d5e 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -7,7 +7,16 @@ on: jobs: trigger-integration-tests: name: Trigger Integration tests - runs-on: ubuntu-latest + strategy: + matrix: + os: + - ubuntu-latest + - ubuntu-24.04-arm + - windows-latest + - windows-11-arm + - macos-latest # arm + - macos-13 # x64 + runs-on: ${{ matrix.os }} env: HELM_3_8_0: 'v3.8.0' HELM_3_7_2: 'v3.7.2' diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 103e541c..d255e638 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -11,7 +11,16 @@ on: # rebuild any PRs and main branch changes jobs: build: # make sure build/ci works properly - runs-on: ubuntu-latest + strategy: + matrix: + os: + - ubuntu-latest + - ubuntu-24.04-arm + - windows-latest + - windows-11-arm + - macos-latest # arm + - macos-13 # x64 + runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 From 2ee52c8d39365b6e4c6c13bb7692edabc045fbaa Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Fri, 20 Jun 2025 11:28:17 +0200 Subject: [PATCH 2/4] Don't fail fast --- .github/workflows/integration-tests.yml | 1 + .github/workflows/unit-tests.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 0e213d5e..e39c0df3 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -16,6 +16,7 @@ jobs: - windows-11-arm - macos-latest # arm - macos-13 # x64 + fail-fast: false runs-on: ${{ matrix.os }} env: HELM_3_8_0: 'v3.8.0' diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index d255e638..cb0f8d02 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -20,6 +20,7 @@ jobs: - windows-11-arm - macos-latest # arm - macos-13 # x64 + fail-fast: false runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 From f7ff798e3b8488f9929fd5b7287acce7c23776f3 Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Fri, 20 Jun 2025 11:34:02 +0200 Subject: [PATCH 3/4] Don't test windows as script would have to be adapted --- .github/workflows/integration-tests.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index e39c0df3..ac2d9e30 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -12,8 +12,6 @@ jobs: os: - ubuntu-latest - ubuntu-24.04-arm - - windows-latest - - windows-11-arm - macos-latest # arm - macos-13 # x64 fail-fast: false From a4d77585e0d70fae75d320a3d0ae806c3ecc41b1 Mon Sep 17 00:00:00 2001 From: Cornelius Roemer Date: Fri, 20 Jun 2025 11:35:32 +0200 Subject: [PATCH 4/4] Use no-v-version that's available on macOS arm --- .github/workflows/integration-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index ac2d9e30..d826a2bc 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -19,7 +19,7 @@ jobs: env: HELM_3_8_0: 'v3.8.0' HELM_3_7_2: 'v3.7.2' - HELM_NO_V: '3.5.0' + HELM_NO_V: '3.8.0' PR_BASE_REF: ${{ github.event.pull_request.base.ref }} steps: - name: Check out repository