Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

HttpRequest throws exception when the body is an IO object #29

@yaxia

Description

@yaxia

HttpRequest throws exception when the body is an IO object, because the code checks whether the body is an IO object but it actually uses the APIs of the File(derived from the IO object): body.size and body.path.

I am going to make a change to fix it. Here are some questions for discussion:

  1. Shall we support File object only? Is it by-design?
  2. Regarding API convenience, an IO or StringIO object may also be the body, shall we support it?

Thoughts? @vishrutshah , @veronicagg

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions