Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

Fixes #6293

This PR updates the schema definitions for Azure configuration to make the project property optional when using the AKS host, restoring the previous behaviour before e22e229.

project is not needed when working with an AKS project with Helm, and there isn't an easy way to express "either project or k8s.helm must be defined".

Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Helm for AKS documentation to include project field Fix AKS schema to allow Helm deployments without project field Jan 5, 2026
Copilot AI requested a review from JeffreyCA January 5, 2026 17:39
@JeffreyCA
Copy link
Contributor

@copilot can you check and verify the logic for the other services ["containerapp", "aks", "ai.endpoint"] didn't regress either in e22e229?

Copy link
Contributor Author

Copilot AI commented Jan 5, 2026

@copilot can you check and verify the logic for the other services ["containerapp", "aks", "ai.endpoint"] didn't regress either in e22e229a26374f814d5a246b8...

Verified the validation logic for all services mentioned. Tests confirm:

containerapp: ✅ No regression - requires image OR project (same as before)
aks: ✅ Fixed - now requires project OR k8s.helm (restores original intent where Helm deployments don't need project)
ai.endpoint: ✅ No regression - requires both project AND config (e22e229 correctly tightened this)

I ran comprehensive schema validation tests for both v1.0 and alpha schemas against 9 test cases covering all these host types.

@JeffreyCA JeffreyCA marked this pull request as ready for review January 5, 2026 18:47
Copilot AI review requested due to automatic review settings January 5, 2026 18:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix a regression introduced in commit e22e229 where AKS services started requiring a project field, breaking Helm-only deployments that reference external charts without local source code. The fix modifies the JSON Schema validation to use an anyOf pattern that allows either a project field OR a k8s.helm configuration.

Key Changes

  • Modified AKS host validation from requiring project to accepting either project OR k8s with helm
  • Updated schema comments to reflect the new validation logic
  • Changes applied consistently to both v1.0 and alpha schemas

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
schemas/v1.0/azure.yaml.json Updated AKS service validation to use anyOf pattern allowing project OR k8s.helm
schemas/alpha/azure.yaml.json Applied same validation change to alpha schema for consistency

@JeffreyCA
Copy link
Contributor

@copilot can we drop the "either project or helm" requirement?

The current validation message from the YAML VS Code Extension can be a bit misleading:

image

…ct OR helm

Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 5, 2026

@copilot can we drop the "either project or helm" requirement?

The current validation message from the YAML VS Code Extension can be a bit misleading:
...

Done in f17e6fa. Simplified the AKS schema to make project entirely optional - removed the "project OR helm" requirement. This eliminates the confusing validation messages.

@JeffreyCA JeffreyCA enabled auto-merge (squash) January 7, 2026 22:58
@JeffreyCA
Copy link
Contributor

/check-enforcer override

@JeffreyCA JeffreyCA merged commit 17be734 into main Jan 7, 2026
4 checks passed
@JeffreyCA JeffreyCA deleted the copilot/update-helm-for-aks-documentation branch January 7, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm for AKS documentation YAML fails schema validation due to missing project field

5 participants