-
Notifications
You must be signed in to change notification settings - Fork 267
Fix AKS schema to allow Helm deployments without project field #6444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Verified the validation logic for all services mentioned. Tests confirm: containerapp: ✅ No regression - requires I ran comprehensive schema validation tests for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix a regression introduced in commit e22e229 where AKS services started requiring a project field, breaking Helm-only deployments that reference external charts without local source code. The fix modifies the JSON Schema validation to use an anyOf pattern that allows either a project field OR a k8s.helm configuration.
Key Changes
- Modified AKS host validation from requiring
projectto accepting eitherprojectORk8swithhelm - Updated schema comments to reflect the new validation logic
- Changes applied consistently to both v1.0 and alpha schemas
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| schemas/v1.0/azure.yaml.json | Updated AKS service validation to use anyOf pattern allowing project OR k8s.helm |
| schemas/alpha/azure.yaml.json | Applied same validation change to alpha schema for consistency |
|
@copilot can we drop the "either project or helm" requirement? The current validation message from the YAML VS Code Extension can be a bit misleading:
|
…ct OR helm Co-authored-by: JeffreyCA <9157833+JeffreyCA@users.noreply.github.com>
Done in f17e6fa. Simplified the AKS schema to make |
|
/check-enforcer override |

Fixes #6293
This PR updates the schema definitions for Azure configuration to make the
projectproperty optional when using the AKS host, restoring the previous behaviour before e22e229.projectis not needed when working with an AKS project with Helm, and there isn't an easy way to express "eitherprojectork8s.helmmust be defined".