Skip to content

Fix: issue related to managed identity authentication #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacqueskangforvia wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: issue related to managed identity authentication #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
191cdfc
fix: UserAssignedIdentityClientId is always empty
jacqueskangforvia Jan 26, 2026
b76d188
fix: wrong parameter provided when getting access token for managed i…
jacqueskangforvia Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions AzureSQLConnectivityChecker.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ if ($null -ne $parameters) {
if ($null -ne $parameters['DelayBetweenConnections']) {
$DelayBetweenConnections = $parameters['DelayBetweenConnections']
}
if ($null -ne $parameters['UserAssignedIdentityClientId']) {
$UserAssignedIdentityClientId = $parameters['UserAssignedIdentityClientId']
}
if ($null -ne $parameters['TrustServerCertificate']) {
$TrustServerCertificate = $parameters['TrustServerCertificate']
}
Expand Down Expand Up @@ -1482,6 +1485,10 @@ try {
TrackWarningAnonymously ('Authentication library:' + $AuthenticationLibrary)
}

if ($null -ne $UserAssignedIdentityClientId -and $UserAssignedIdentityClientId -ne '') {
Write-Host ' UserAssignedIdentityClientId:' $UserAssignedIdentityClientId -ForegroundColor Yellow
}

Write-Host ' Server:' $Server -ForegroundColor Yellow

if ($null -ne $Database) {
Expand Down
6 changes: 3 additions & 3 deletions TDSClient/TDSClient/AuthenticationProvider/AuthenticationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,9 @@ private async Task<string> GetAccessTokenForInteractiveAuth()
/// <returns></returns>
private async Task<string> GetAccessTokenForMSIAuth()
{
return IdentityClientId != null ?
await MSALHelper.GetSQLAccessTokenFromMSALUsingUserAssignedManagedIdentity(Authority, IdentityClientId) :
await MSALHelper.GetSQLAccessTokenFromMSALUsingSystemAssignedManagedIdentity(Authority);
return string.IsNullOrEmpty(IdentityClientId) ?
await MSALHelper.GetSQLAccessTokenFromMSALUsingSystemAssignedManagedIdentity(Resource) :
await MSALHelper.GetSQLAccessTokenFromMSALUsingUserAssignedManagedIdentity(Resource, IdentityClientId);
}
}
}