Skip to content

[Test] Improve metadata comparison robustness #39

@coderabbitai

Description

@coderabbitai

Context

From PR #34 review discussion: #34

The test uses JSON.stringify() to compare metadata, which can fail if key ordering differs even when the objects are semantically equivalent.

Problem

  • Comparison is fragile to key ordering
  • Doesn't account for any transformations the resolver might apply to metadata
  • Compares against original cell metadata, not resolver output

Impact

Low priority - could cause false positives but hasn't been an issue in practice.

Suggested Enhancement

Use a deep-equal comparison library that ignores key ordering, or normalize/sort keys before comparison.

Backlinks:

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions