Skip to content

[Test] Verify source format consistency (string vs array) #35

@coderabbitai

Description

@coderabbitai

Context

From PR #34 review discussion: #34

The integration test normalizes all cell sources to strings for comparison, which could mask format inconsistencies where some cells have source as a string and others as an array.

Problem

  • Resolved conflict cells use: source: resolvedContent.split(/(?<=\n)/) (always array)
  • Identical cells use: cellToUse = currentCell || incomingCell || baseCell (keeps original format)
  • Test's getCellSource() normalizes both, hiding potential issues

Impact

Low priority - doesn't affect core functionality but could cause issues with some notebook tools that expect consistent formatting.

Suggested Enhancement

Add a check after writing the notebook to verify all cells use the same source format (all strings or all arrays).

Backlinks:

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions