Skip to content

Listing resolvable markets needs to be paginated, removed from market factory #1293

@robert-e-davidson3

Description

@robert-e-davidson3

Reading from ethereum nodes doesn't take any gas but many ethereum nodes use a timeout low enough that listResolvableEvents and similar will fail as the number of markets increases. This is currently causing issues with the SportsLinkMarketFactory, at around 550 markets.

Also, there's no reason for this read-only method to be part of the market factory itself. Since market factory contract size is at a premium, it's better to expose the right read methods and move this code into the fetcher or a specialized contract.

Subtasks:

  • Solidity changes
  • Adapter does pagination.
  • Deploy changes
  • Tests

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions