[Bug] Jumping to a testimony statement breaks pairs

[in1tiate]

The function that handles jumping to an arbitrary statement sets the sender's position to "wit" internally, which breaks internal pair data. This is the actual cause of the elusive "clicking the shout buttons breaks pairing" bug.

Suggested fix: Don't set the user's position at all. I don't know why we do this, as none of the following operations require it.

[collinxchu]

I agree with the fix -- some backgrounds such as the ace attorney investigations backgrounds may have the "witness" in a different position to start with than wit, as well. Seems like hardcoded nonsense to patch some other problem.

[Salanto]

I agree with the fix -- some backgrounds such as the ace attorney investigations backgrounds may have the "witness" in a different position to start with than wit, as well. Seems like hardcoded nonsense to patch some other problem.

That is incorrect. I did it because I thought to myself: "The only spot someone realistically should record from is the witness position so pro and def can't interrupt a testimony recording."

[collinxchu]

I agree with the fix -- some backgrounds such as the ace attorney investigations backgrounds may have the "witness" in a different position to start with than wit, as well. Seems like hardcoded nonsense to patch some other problem.

That is incorrect. I did it because I thought to myself: "The only spot someone realistically should record from is the witness position so pro and def can't interrupt a testimony recording."

Fair enough, you know what they say about assumptions.

[in1tiate]

Returned as an issue. This will require some more significant reworks to fix