[BUG] - Output Error?

[CarlosFongo]

Bug Report Template for MauticSmartSend

Bug Description:
Tried running your 1.0.1 script using the following terminal command, signed in as the mautic folder and smartsend script owner:
./mautic_smartsend.sh

The "failure" message output seems like a Task failed successfully situation?

• It only sends one batch of emails, whatever the Message Limit is set to. I've tried setting the sleep time to 1, 2, or even 6. Currently set to 6.

---

Expected Behavior:

• To run and execute all 500+ emails in the queue.

---

Actual Behavior:

• It only sends one batch of emails, whatever the Message Limit is set to. I've tried setting the sleep time to 1, 2, or even 6. Currently set to 6.

---

Terminal Output:

here’s the output, i replaced my user with something generic.

mautic@generic:/srv$ ./mautic_smartsend.sh 
Detected PHP Version: 8.0.30
Detected Mautic Version: 4.4.10
Error: Mautic command failed.=============
Mautic provided the following error message:               
Sending in this cycle: 14                        
 [2023-11-01 19:04:26] Processing default mailer spool... 
 14 emails senth time: Calc...                     

---

Screenshots:

---

Environment Details:

• Operating System:
  Distributor ID: Ubuntu
  Description: Ubuntu 22.04.3 LTS
  Release: 22.04
  Codename: jammy
• PHP Version:
  PHP 8.0.30 (cli) (built: Sep 2 2023 08:05:13) ( NTS )
  Copyright (c) The PHP Group
  Zend Engine v4.0.30, Copyright (c) Zend Technologies
  with Zend OPcache v8.0.30, Copyright (c), by Zend Technologies
• Mautic Version: 4.4.10
• MauticSmartSend Version (if applicable): 1.0.1

[chartist1]

Not sure how this is expected to work really.
Line 71 of the script:

if [ $MAUTIC_EXIT_STATUS -ne 0 ] || [[ ! -z "$MAUTIC_OUTPUT" ]]; then

Checks if the mautic command does not return an error exit status and does not return any other output
but it always returns some text output, unless you use -q --quiet on the command at least that is what
the help for my version of mautic:emails:send says, I am running version 4.4.10

Perhaps on other versions of mautic:emails:send this was not the case

I changed line 71 to this:

if [ $MAUTIC_EXIT_STATUS -ne 0 ]; then

And it works a treat

[chartist1]

As a separate thing I also modified line line 67:
MAUTIC_OUTPUT=$($PHP_EXEC $BIN_DIR/console mautic:emails:send --message-limit $MESSAGE_LIMIT 2>&1)
to this:
MAUTIC_OUTPUT=$($PHP_EXEC $BIN_DIR/console mautic:emails:send --no-interaction --no-ansi --message-limit $MESSAGE_LIMIT 2>&1)

Prevent the mautic command from asking any interactive questions and turn off any ANSI formatting in the output text

[AsyncAlchemist]

Hi, send a PR (bump the version number please) and I will merge it.

[chartist1]

Hi, unfortunately I do not have git installed anywhere to be able to check in changes and do that.

[zitob9]

Hi, unfortunately I do not have git installed anywhere to be able to check in changes and do that.

How do you integrate the script with the cron job?

[chartist1]

Hi
I have these settings in the script
Line 32
MESSAGE_LIMIT=1

Line 35
SLEEP_TIME=2

And this in my /etc/crontab

Send emails from spool queue,currently 1 message every 2 seconds continuously until all sent

*/1 * * * * root /usr/local/sbin/mautic_smartsend.sh -s >> /var/log/mautic/mautic_smartsend.log 2>&1