Skip to content

Incompatibility with Timely  #8

@leepowers

Description

@leepowers

The Now Reading Redux plugin has a function definition clash with the Timely All-In-One Event Calendar at http://time.ly

Both plugins declare a url_get_contents function in the global namespace:

NRR in file amazon.php line 24

Timely in file lib/global-functions.php line 16

I hacked together a solution by running a simple search and replace in amazon.php, exchanging all instances of url_get_contents with nrr_url_get_contents.

In the future I would suggest namespacing functions in one of these ways:

  • Utilizing PHP namespaces (available since 5.3)
  • Encapsulating global functions into a class
  • Adding a Now Reading Redux prefix to all global functions, url_get_contents() > nrr_url_get_contents

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions