Validation Processor: Processing fails for primitive types

[cwbriones]

Example class:

package com.example;

import com.arpnetworking.commons.builder.OvalBuilder;
import net.sf.oval.constraint.Min;

public class MyClass {
    private final int _value;

    public MyClass(final Builder builder) {
        _value = builder._value;
    }

    public static class Builder extends OvalBuilder<MyClass> {
        @Min(1)
        private int _value = 1;

        public Builder() {
            super(MyClass::new);
        }

        public Builder setValue(final int value) {
            _value = value;
            return this;
        }
    }
}

This results in the following compile error during annotation processing:

Class processing failed: javassist.CannotCompileException: [source error] isSatisfied(com.example.MyClass$Builder,int,Object,Object) not found in net.sf.oval.constraint.MinCheck

Full Stack Trace

[cwbriones]

It works if you used a box Integer instead of int.

[vjkoskela]

The convention with Commons builders is to use nullable types for all fields. This allows detecting the setting of required fields without the need for a separate "has" field for each data field. Of course, it's not perfect since if null is an acceptable value it cannot be distinguished from a field that has not been set. In general, we have not found this to be a problem. The documentation could probably be improved around how to use this pattern effectively.

[cwbriones]

The convention with Commons builders is to use nullable types for all fields

If that's the case then I think the best out of this is documentation like you mentioned, or even just a better error message. I had expected this to work since the OVal examples used primitives but I suppose the commons validator already uses those annotations without the same usage supported.