Skip to content

Make Frame and Module abstract classes to enforce implementation in derived classes #421

@yashrajsapra

Description

@yashrajsapra

Description:
The Frame and Module base classes currently allow instantiation without enforcing certain behaviors in derived classes. To ensure all derived classes provide their own specific implementations, these base classes should be made abstract.

Proposed Change:

Declare the relevant methods in Frame and Module as pure virtual so that both classes become abstract.
This will prevent accidental instantiation of incomplete derived classes.

Rationale:

Enforces compile-time implementation requirements.
Prevents silent fallback to default behavior.
Improves maintainability by making design intent explicit.

Impact:

Breaking change: All existing derived Frame and Module classes will need to implement the required methods.
No runtime overhead — this is purely a compile-time enforcement.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. chrome, safari]
  • Cuda Version [e.g. 22]
  • Architecture [e.g. x86_64, arm64]

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions