From 415c9aa3be73d0e0f7a7e940d416cdc1f9e14ab5 Mon Sep 17 00:00:00 2001 From: Kariamos Date: Thu, 5 Feb 2026 12:04:11 +0100 Subject: [PATCH] feat: update attachment deletion logic to ensure database records are removed after S3 deletion --- .../campaignId/finance/otherCosts/_delete/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/routes/campaigns/campaignId/finance/otherCosts/_delete/index.ts b/src/routes/campaigns/campaignId/finance/otherCosts/_delete/index.ts index 45234b047..754e6eca3 100644 --- a/src/routes/campaigns/campaignId/finance/otherCosts/_delete/index.ts +++ b/src/routes/campaigns/campaignId/finance/otherCosts/_delete/index.ts @@ -63,6 +63,9 @@ export default class OtherCostsDeleteRoute extends CampaignRoute<{ for (const attachment of attachments) { try { await deleteFromS3({ url: attachment.url }); + await tryber.tables.WpAppqCampaignOtherCostsAttachment.do() + .where({ id: attachment.id }) + .delete(); } catch (e) { console.error( `Error deleting attachment from S3: ${attachment.url}`, @@ -70,9 +73,6 @@ export default class OtherCostsDeleteRoute extends CampaignRoute<{ ); throw new Error("Error deleting attachment from S3"); } - await tryber.tables.WpAppqCampaignOtherCostsAttachment.do() - .where({ id: attachment.id }) - .delete(); } }