Enquiry for supporting vscode terminal

[jingwangsg]

Is your feature request related to a problem? Please describe.
Most of cases I use vscode tunnel to access remote server for convenience. Without proxy, ssh access within normal simluater (e.g. iTerm2) is impossible.

Describe the solution you'd like
It would be great if termvisage can support vscode internal terminal simulater.

Describe alternatives you've considered
Of course, I can use proxy to use ssh in iTerm2. Also, if tmux will supported soon, it should be a great alternative, since I'm able to run tmux inside vscode directly.

Additional context
Add any other context or screenshots about the feature request here.

[AnonymouX47]

Hello!

Thanks for the request.

I'm yet to test this viewer (and term-image, the library it depends on) on xterm-addon-image which the VS Code terminal depends on.

In the mean time, please ensure image support is enabled and try to run termvisage with the options -S iterm2 --force-style. Though, I suspect output may be sorta garbled due to xterm-addon-image's cursor placement policy being different from the norm. Anyways, please let me know the results.

Once I've been able to test on xterm.js, I'll make any neccessary changes upstream (at term-image) to get things working out of the box.

Thanks.

[AnonymouX47]

About tmux support, that's planned and should hopefully come soon (though, to the library, term-image first) but note that there are various limitations to using graphics protocols within tmux.

[jingwangsg]

Hello!

Thanks for the request.

I'm yet to test this viewer (and term-image, the library it depends on) on xterm-addon-image which the VS Code terminal depends on.

In the mean time, please ensure image support is enabled and try to run termvisage with the options -S iterm2 --force-style. Though, I suspect output may be sorta garbled due to xterm-addon-image's cursor placement policy being different from the norm. Anyways, please let me know the results.

Once I've been able to test on xterm.js, I'll make any neccessary changes upstream (at term-image) to get things working out of the box.

Thanks.

Turning on Image Support and adding options -S iterm2 --force-style work great on latest vscode! Many thanks for your guidance and hard working:)

A minor issue is that the picture will lose a small portion at its bottom left corner. However, this does not affect the overall experience so far.

[AnonymouX47]

Turning on Image Support and adding options -S iterm2 --force-style work great on latest vscode! Many thanks for your guidance and hard working:)

Glad to hear that 😃 and thanks for the quick response. You're welcome.

A minor issue is that the picture will lose a small portion at its bottom left corner. However, this does not affect the overall experience so far.

I see... as expected. It's due to the cursor-positioning issue with xterm-addon-image that I mentioned earlier. The "garbled" was actually referring to the TUI mode.

I intend to open an issue at the concerned repository after I've looked into it properly. I'll wait for the developer's response to this before going ahead with adding out-of-the-box support for the terminal emulator.

In the mean time, you can add the -H right option to apply right alignment to images. This should help avoid the erasure of some portion of the last line.

I'll get back to you as soon as there's any development.

Thank you.