Skip to content

Test coverage: Admin controllers (knowledge sources, summaries, jobs, blocklists) #58

@AndreRobitaille

Description

@AndreRobitaille

Summary

Admin controller test coverage has expanded since this issue was filed but gaps remain.

What's already covered

  • Topicsadmin/topics_controller_test.rb, admin/topics_review_test.rb, admin/topics_controller_description_test.rb
  • Committeesadmin/committees_controller_test.rb (9 tests: CRUD, alias create/destroy)
  • Membersadmin/members_controller_test.rb (6 tests: index, show, alias CRUD, merge, merge-into-self rejection)

Controllers still needing tests

Admin::KnowledgeSourcesController

  • CRUD operations (create, read, update, delete)
  • File upload handling
  • reingest action (re-processes knowledge source)

Admin::SummariesController

  • Show action (view summaries for a meeting)
  • regenerate_all — Regenerates all summaries for a meeting
  • regenerate_one — Regenerates a single summary

Admin::JobsController

  • Show action (job queue dashboard)
  • retry_failed — Retry a single failed job
  • retry_all_failed — Retry all failed jobs
  • discard_failed — Discard a failed job
  • clear_completed — Clear completed job records

Admin::TopicBlocklistsController

  • CRUD operations for blocklist entries

Approach

  • Follow patterns from existing admin/committees_controller_test.rb
  • Use fixtures for test data
  • Verify authentication is enforced on all actions
  • Test both success and error paths

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions