Skip to content

Commit 205c7dd

Browse files
author
Amperstrand
committed
Add UNTESTED warnings to SCP03 and AES-CMAC modules
SCP03 code exists but has not been tested on any hardware. Only SCP02 is verified (19/19 hardware, 54/54 CI tests). See GitHub issue #26 for testing roadmap and contribution guide.
1 parent 6e70c4e commit 205c7dd

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

src/keystore/javacard/gp/aes_cmac.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
"""AES-CMAC (NIST SP 800-38B) implementation.
22
33
Pure Python using ucryptolib AES-128-ECB. Used by SCP03 for secure messaging MAC.
4+
5+
WARNING: Not tested on hardware. Only SCP02 is currently verified.
46
"""
57

68
from ucryptolib import aes as _aes

src/keystore/javacard/gp/scp03.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
AES-128-CBC for encryption, AES-CMAC for message authentication.
55
66
Reference: kaoh/globalplatform/src/crypto.c, OpenJavaCard SCP03Derivation.java
7+
8+
WARNING: This SCP03 implementation has NOT been tested on hardware.
9+
Only SCP02 is currently verified (19/19 hardware tests, 54/54 CI tests).
10+
See GitHub issue #26 for SCP03 testing roadmap and how to contribute.
711
"""
812

913
from ucryptolib import aes as _aes

0 commit comments

Comments
 (0)