User Registration Test Fails Due to Existing Test Data

[AmeliaES]

CodeSpace-Portfolio/cypress/e2e/register.cy.js

Lines 19 to 34 in 05c8779

	it('registers a new user succesfully', () => {
	cy.get('[data-cy="firstName"]').type('TestUserForCypress');
	cy.get('[data-cy="lastName"]').type('TestUserForCypressLastName');
	cy.get('[data-cy="email"]').type('test_user123@email.com');
	cy.get('[data-cy="phone"]').type('1234567890');
	cy.get('[data-cy="adLine1"]').type('123 Test Address');
	cy.get('[data-cy="adLine2"]').type('Test Address Line 2');
	cy.get('[data-cy="country"]').type('UK');
	cy.get('[data-cy="password"]').type('123456');
	cy.get('[data-cy="confirmPassword"]').type('123456');
	cy.get('[data-cy="submit"]').click();
	// get toast and check for success message
	cy.get('[data-cy="toastText"]').should(
	'have.text',
	'You are now registered'
	);

Here the first time we run this test it creates a new test user. However, when we run it again the user is already existing in the database. The test fails as it displays a "danger" toast with error message, rather than a "success" toast.

[AmeliaES]

Use a clean up after this test suite is run that removes that test user. Remove the test user after we have tested the log in page though, and all the features that occur in the session when a user is logged in, ie. can view products.php page and the welcome message contains the user name.

This may help:
https://learn.cypress.io/advanced-cypress-concepts/database-initialization-and-seeding
https://www.browserstack.com/guide/cypress-database-testing

[AmeliaES]

Tried cleaning up test data by:

CodeSpace-Portfolio/cypress/e2e/register.cy.js

Lines 3 to 10 in bb6cbb1

	const email = 'test+test@MKTIMEdomainForTesting.com';
	const deleteUserQuery = `mysql -u root -S /Applications/XAMPP/xamppfiles/var/mysql/mysql.sock -D MKTIMEportfolio -e "DELETE FROM users WHERE email='${email}'"`;
	beforeEach(() => {
	// Remove test user before tests start
	cy.exec(deleteUserQuery).then((result) => {
	cy.log('User cleanup before test:', result);
	});

However, I'm really not satisfied this is appropriate. It seems risky to keep SQL commands deleting a user in the production database inside a test. What might be better is to create a separate test database and to use an API call, so the delete test user is defined in the app logic not in the test logic.