Site performance

[AlexRaubach]

Heroku has Metawing's average response time at 863 ms while ListFortress is at 63ms.

I suspect that there are multiple issues including the following:

• Turbolinks doesn't seem to be set up correctly

• Metawing is using the db as a keyvalue store instead of a faster cache

• The image functionality needs work and might be loading them too frequently?

• The views alone take a long time to render

[AlexRaubach]

Turbolinks seems to be fixed with 71a60e1

[AlexRaubach]

I initially thought the problem was in the link_with_filter_to function but while that function is running hundreds of times per table, I don't think it's actually taking that long.

the real problem seems to be the ship icon lookup which makes a db call to figure out which icon belongs to a pilot.

[AlexRaubach]

842bb8b solves the pilot index page performance issues. Seems like the biggest remaining problem is the ffg images and their controller.

[AlexRaubach]

I also took out the only remaining KeyValueStoreRecord call. It was checking for maintenance mode and since I don't ever use that, thanks to heroku, it could be removed.

[AlexRaubach]

The above measures have helped, the root of the problem is that each image calls ImageController show which then calls Pilot.find, Upgrade.find + UpgradeSide.find_by or Condition.find. Since the index pages have 200+ images on them, that causes a ton of unneeded db calls.

Deliver image just needs the url of the image passed to it, so I would start by making a new method that only needs the image url string and then switching all the image calls over to it.

[AlexRaubach]

FFG stopped hosting images for their squadbuilder that everyone, including metawing, was hotlinking both to avoid storing/updating images and because it's a lot easier. Since AMG took over and they replaced the squadbuilder, free image hotlinks are dead. I decided to just copy all the images from https://github.com/CrazyVulcan/x-wing2.0-project-goldenrod the en pilots and upgrades and just link them directly in metawing. This was a minimal amount of work and it does seem to help with page load speed (although I'm on a very high speed connection).

Page load times could still use work but that will probably require more difficult optimizations. Lazy loading images, db query optimizations, pagination that works with the url link params to return less data are some of the obvious ways to improve.