[BUG] Editing brightness and contrast creates syncing loop since v1.19.1

[Yquas]

Which app is your issue for

Document Scanner

Version

v1.19.1 Build 140

What platform are you using?

Android

OS Version

16

What happened?

When using "Sync document PDFs", editing a document's brightness or contrast gets the app into a very long or infinite syncing loop. The only way to stop it is closing the app from recents, and when you reopen it, the document is marked as unsynced most of the time.

Could be related to the changes made to fix #550 ?

You can perfectly see it now with the new sync notification you added, setting it up so it shows the icon on top of the screen while turning off it's sound so it's not annoying. Good for debugging purposes without good programming knowledge, thanks!

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[farfromrefug]

@Yquas thanks will be fixed in next version

[Yquas]

@farfromrefug Hey, I'm not sure if this is what you were going to fix in the next version, but I found out the reason for this loop.

It is not infinite. I tend to scroll through the contrast and brightness bar, holding my finger onto it and moving around until I decide what exact document look I want. And that's what the app kept processing, every number I've scrolled through. That's a lot, so I though it was infinite at first, but it did end after a while.
If you only tap the bar, don't scroll it and let the app sync, it only does it once as it should.

And this is the result of a request I've had in another issue: That the app should only start syncing PDFs when the user is done interacting, not at every single change and touch. I'd find it better if it only did it after the user leaves the document they were editing or at least the page, but that's up to you.

[farfromrefug]

@Yquas yes this is what i fixed! i now throttle the sync to ensure i wait for you to be finished

[Yquas]

@farfromrefug Nice, and what time did you set it to? A few seconds or more like 10s? I'd like a higher number better, of course, but it also shouldn't be too much so the app doesn't wait around in the background when it's maybe already been closed.

And does the timer reset at every new interaction that happens before it has reached 0 or not?

[farfromrefug]

@Yquas no the throttle is around 1s. But that should be enough when modify brightness/contrast.
I could imagine a sync setting to "throttle" sync itself to something much bigger like 1m/30min (i would use alarm to trigger the sync)

[Yquas]

@farfromrefug You could use an alarm if you think that's the better solution. I'm still more on the "save on exit" side, many apps just don't do anything until you click save, but with this app having no manual save flow it's up to you how you wan't to handle it.
Then it doesn't matter if the user closes the app as long as they gave the alarm permission, right?

[farfromrefug]

@Yquas There is no "save" action in the app, everything is saved automatically. The issue is only with sync and there i can t do much more than throttling.

Yes about the permissions/alarm/close