Minor PPropertyParser improvments

Author: AdventureT

Toshi/Include/TKernel/TPCString.h

@@ -186,6 +186,7 @@ class TKERNELINTERFACE_EXPORTS TCStringPool
 
 	TPCString Get(TPCCHAR a_szString);
 	TPCString Get(TINT a_iInt);
+	TPCString Get(const TCString &a_sString);
 
 protected:
 	void Remove(TPooledCString &a_rPooledCString);

Toshi/Plugins/Include/PPropertyParser/PProperties.h

@@ -21,8 +21,8 @@ class PPROPERTYPARSER_EXPORTS PProperties : Toshi::TObject
 		// $PPropertyParser: FUNCTION 10001e30 COMPLETED
 		PProperty(const PPropertyName &a_rName, const PPropertyValue &a_rValue)
 		{
-			m_oName  = PPropertyName(a_rName);
-			m_oValue = PPropertyValue(a_rValue);
+			m_oName  = a_rName;
+			m_oValue = a_rValue;
 		}
 		// $PPropertyParser: FUNCTION 10001e70 COMPLETED
 		PProperty(const PPropertyName &a_rName, const PPropertyValue &a_rValue, const Toshi::TPCString &a_rComment)

Toshi/Plugins/Source/PPropertyParser/PProperties.cpp

@@ -175,9 +175,7 @@ const PPropertyValue *PProperties::GetProperty(const PPropertyName &a_rPropertyN
 
 const PPropertyValue *PProperties::GetProperty(const TPCString &a_rPropertyName, TINT a_iIndex) const
 {
-	// This format is in the binary but seems unused
-	TCString().Format("%i", a_iIndex);
-	return GetProperty(PPropertyName(a_rPropertyName, TSystem::GetCStringPool()->Get(a_iIndex)));
+	return GetProperty(PPropertyName(a_rPropertyName, TSystem::GetCStringPool()->Get(TCString().Format("%i", a_iIndex))));
 }
 
 const PPropertyValue *PProperties::GetProperty(const TPCString &a_rPropertyName, const TPCString &a_rPropertySubname) const

Toshi/Source/TKernel/TPCString.cpp

@@ -17,6 +17,7 @@ TCStringPool::TCStringPool(TINT a_iMaxSize, TINT a_iInitialSize)
 	m_oPooledCStrings = TArray<TPooledCString>(a_iMaxSize, a_iInitialSize);
 }
 
+// $TKernelInterface: FUNCTION 10028000
 TPCString TCStringPool::Get(TPCCHAR a_szString)
 {
 	if (!a_szString || TSystem::StringLength(a_szString) == 0) {
@@ -34,11 +35,18 @@ TPCString TCStringPool::Get(TPCCHAR a_szString)
 	return TPCString(string);
 }
 
+// $TKernelInterface: FUNCTION 100281f0
 TPCString TCStringPool::Get(TINT a_iInt)
 {
 	return Get(TCString().Format("%d", a_iInt));
 }
 
+// $TKernelInterface: FUNCTION 10028ee0
+TPCString TCStringPool::Get(const TCString &a_sString)
+{
+	return Get(a_sString.GetString());
+}
+
 // $TKernelInterface: FUNCTION 10028d10
 void TCStringPool::Remove(TPooledCString &a_rPooledCString)
 {