Preview deployments broken (likely `@sveltejs/adapter-cloudflare@5.0.0` related)

[techniq]

LayerChart preview deployments started failing yesterday (and Svelte UX 2 weeks ago) with Could not resolve "../output/server/index.js" (and other path) errors.

I believe it is attributed to updating @sveltejs/adapter-cloudflare to 5.0.0 or possibly the latest wrangler (3.95.0 => 3.105.1), but I'm having trouble confirming or identifying a solution. I thought maybe needing to change directory setting but I couldn't find any details on what it should change to. Also, the production deployments have been working.

Click for details

✘ [ERROR] Build failed with 2 errors:

  ✘ [ERROR] Could not resolve "../output/server/index.js"
  
      _worker.js:2:23:
        2 │ import { Server } from "../output/server/index.js";
          ╵                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
  
  ✘ [ERROR] Could not resolve "../cloudflare-tmp/manifest.js"
  
      _worker.js:3:49:
        3 │ ...est, prerendered, base_path } from "../cloudflare-tmp/manifest.js";
          ╵                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
  


✘ [ERROR] Build failed with 2 errors:

  ✘ [ERROR] Could not resolve "../output/server/index.js"
  
      _worker.js:2:23:
        2 │ import { Server } from "../output/server/index.js";
          ╵                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
  
  ✘ [ERROR] Could not resolve "../cloudflare-tmp/manifest.js"
  
      _worker.js:3:49:
        3 │ ...est, prerendered, base_path } from "../cloudflare-tmp/manifest.js";
          ╵                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Any thoughts on what might have changed and how to fix? Thanks!

[techniq]

@AdrianGonz97 The issue is definitely related to no longer running the esbuild step in @sveltejs/adapter-cloudflare@5.0.0.

To fix the Could not resolve "../output/server/index.js" and similar errors, I refined build-preview.yml to include output and cloudflare-tmp in the uploaded artifact.

      - name: Upload build artifact
        uses: actions/upload-artifact@v4
        with:
          name: preview-build
          path: |
            packages/layerchart/.svelte-kit/cloudflare
            packages/layerchart/.svelte-kit/cloudflare-tmp
            packages/layerchart/.svelte-kit/output

and then updated deploy-preview.yml to include /cloudflare directory

            - name: Deploy to Cloudflare Pages
              uses: AdrianGonz97/refined-cf-pages-action@v1
              with:
                  apiToken: ${{ secrets.CF_API_TOKEN }}
                  accountId: ${{ secrets.CF_ACCOUNT_ID }}
                  githubToken: ${{ secrets.GITHUB_TOKEN }}
                  projectName: layerchart
                  deploymentName: Preview
                  directory: ${{ steps.preview-build-artifact.outputs.download-path }}/cloudflare

While this solved the ../output/server/index.js and ../cloudflare-tmp/manifest.js import issues, I'm now unable to resolve any of the NPM dependencies (such as d3-shape, d3-scale, @layerstack/utils, etc).

Based on the PR it looks like this should be handled by wranger.

This PR removes the esbuild step from the Cloudflare adapter since Wrangler now bundles the worker for us when deploying from the Cloudflare dashboard or via the Wrangler CLI. sveltejs/kit#13072 (comment)

For now I'm going to downgrade to @sveltejs/adapter-cloudflare@4.9.0 as I haven't had a PR preview in a few weeks.

[techniq]

FWIW, downgrading to @sveltejs/adapter-cloudflare@4.9.0 (and reverting the workflow directory changes) restored PR deployments.

[AdrianGonz97]

Thanks for the heads-up! I'll aim to resolve this at some point this week.

[techniq]

@AdrianGonz97 No rush, but I appreciate it!

[techniq]

@AdrianGonz97 have you had a chance to look into this?

I've been keeping @sveltejs/adapter-cloudflare pinned to 4.x in a few packages but not sure if there will be compat issues with @sveltejs/kit / wrangler at some point. Thanks!

[AdrianGonz97]

@techniq Apologies for the long delay! For Runed, I've updated the artifact upload step to upload the entirety of the .svelte-kit dir here: svecosystem/runed#258 and it seems to be working.

As for the issue of resolving NPM dependencies: Are those dependencies listed as dependencies instead of devDependencies in your package.json? If so, esbuild is likely excluding them from the bundle for that reason.

[techniq]

@AdrianGonz97 No worries, thanks for following up!

Looks like I was close earlier with the path: packages/layerchart/.svelte-kit and directory: ${{ steps.preview-build-artifact.outputs.download-path }}/cloudflare changes 😁

Regarding the dependencies, that definitely looks like the issue based on what's in dependencies and failures I was seeing, but I'm a little confused as to the rule of what should still be considered a devDependency.

[AdrianGonz97]

Sorry, I misspoke when I said it was esbuild. It's actually Vite that's not bundling your deps in the .svelte-kit/output build dir.

Try adding this to your vite.config.js to force Vite to bundle your deps:

// ...
const config = {
  resolve: {
    noExternal: true,
  },
  // ...
};

Let me know if that works!

[techniq]

Interestingly... I setup a PR and slowly made the changes across a couple commits.

After just changing:

• path: packages/layerchart/.svelte-kit
• directory: ${{ steps.preview-build-artifact.outputs.download-path }}/cloudflare
• and then adding include-hidden-files: true

everything appears to build and deploy successfully BUT the page returns a 404 😢

I didn't make any changes to vite.config.js or package.json deps as everything turned green.

I saw the wrangerVersion updates in the runed PR. Should I make those as well, or have any other ideas as to why it's not serving?

Thanks for all your help!

[AdrianGonz97]

Yep, that's expected! I also experienced that in the Runed PR as well.

That happens because the changes in the deploy-preview workflow won't go into effect until those changes have been pushed into the main branch of the repo. It's a sort-of github safety mechanism for certain action events that run in a privileged environment.

I saw the wrangerVersion updates in the runed PR. Should I make those as well

I don't think that'll be necessary